Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QML: Do not alias associated anchor property (for Qt 5.12 compatiblity) #3963

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Jun 7, 2021

May fix the issue reported here: #3961 (comment)

@Holzhaus Holzhaus added this to In progress in QML GUI via automation Jun 7, 2021
@Holzhaus Holzhaus requested a review from daschuer June 7, 2021 15:20
@github-actions github-actions bot added the skins label Jun 7, 2021
@Holzhaus
Copy link
Member Author

Holzhaus commented Jun 7, 2021

@daschuer does this work for you?

@daschuer
Copy link
Member

daschuer commented Jun 8, 2021

Unfortunately it is not completely fixed

Info [Main] Loaded skin "QMLDemo"
debug [Main] DbConnectionPooled - Found thread-local database connection "MIXXX-1" QSqlDatabase(driver="QSQLITE", database="file:///home/sperry/.mixxx/mixxxdb.sqlite", host="", port=-1, user="mixxx", open=true)
debug [Main] Key plugin ID: "qm-keydetector:2"
info [Main] Loaded skin "QMLDemo"
warning [Main] file:///home/sperry/workspace/mixxx/res/skins/QMLDemo/main.qml:54:9: Type Skin.DeckRow unavailable 
             Skin.DeckRow { 
             ^
warning [Main] file:///home/sperry/workspace/mixxx/res/skins/QMLDemo/DeckRow.qml:71:5: Type Deck unavailable 
         Deck { 
         ^
warning [Main] file:///home/sperry/workspace/mixxx/res/skins/QMLDemo/Deck.qml:62:9: Type Skin.WaveformOverview unavailable 
             Skin.WaveformOverview { 
             ^
warning [Main] file:///home/sperry/workspace/mixxx/res/skins/QMLDemo/WaveformOverview.qml:126:9: Type MixxxControls.WaveformOverview unavailable 
             MixxxControls.WaveformOverview { 
             ^
warning [Main] file:///home/sperry/workspace/mixxx/res/skins/QMLDemo/Mixxx/Controls/WaveformOverview.qml:45:9: Type MixxxControls.WaveformOverviewMarker unavailable 
             MixxxControls.WaveformOverviewMarker { 
             ^
warning [Main] file:///home/sperry/workspace/mixxx/res/skins/QMLDemo/Mixxx/Controls/WaveformOverviewMarker.qml:8:14: Expected token `:' 
         required property string group 
                  ^
warning [Main] Skin "QMLDemo" failed to load!
warning [Main] Configured skin  "QMLDemo"  failed to load, falling back to default skin  "LateNight"

@Swiftb0y
Copy link
Member

Swiftb0y commented Jun 8, 2021

Can we create a pre-commit hook that just bans "required" from all qml files for now? xD

@Holzhaus Holzhaus force-pushed the qml-assoc-property-alias-fix branch from 5fdcc04 to 26b7e7d Compare June 8, 2021 23:14
@Holzhaus Holzhaus force-pushed the qml-assoc-property-alias-fix branch from 26b7e7d to 2e67ffd Compare June 8, 2021 23:16
@Holzhaus
Copy link
Member Author

Holzhaus commented Jun 8, 2021

@daschuer please check again

@ninomp
Copy link
Contributor

ninomp commented Jun 9, 2021

This fixes the issue for me on Linux Mint 20.1

@uklotzde
Copy link
Contributor

uklotzde commented Jun 9, 2021

@daschuer Merge?

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now, thank you. LGTM

@daschuer daschuer merged commit e8d9ae3 into mixxxdj:main Jun 9, 2021
QML GUI automation moved this from In progress to Done Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants