QML: Use x axis in knob mouse interaction code like legacy skins do #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, that works good now. Waiting for CI. |
daschuer
approved these changes
Jun 9, 2021
|
CI succeeded. LGTM |
Realistically, only the pre-commit hook was able to fail anyway, because this is qml-only PR. I was looking into making a smoke test the instantiates the coreservices class and then instantiates a skin. That would also help to detect Qt 5.12 incompatibilities, but unfortunately mixxx core and GUI are too entangled atm. For example, the test spawned a blocking qfilepicker because there was no library set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.