Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skins/QMLDemo: Use async coverart loading #3972

Merged
merged 1 commit into from
Jun 10, 2021
Merged

skins/QMLDemo: Use async coverart loading #3972

merged 1 commit into from
Jun 10, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Jun 9, 2021

No description provided.

@Holzhaus Holzhaus added this to In progress in QML GUI via automation Jun 9, 2021
@github-actions github-actions bot added the skins label Jun 9, 2021
Swiftb0y
Swiftb0y approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it actually does anything since we're not loading the image from the file system but through the asyncimageprovider iirc but it doesn't hurt to enable regardless

@Swiftb0y Swiftb0y merged commit b4aa128 into mixxxdj:main Jun 10, 2021
QML GUI automation moved this from In progress to Done Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
skins
Projects
QML GUI
Status: Done
QML GUI
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Holzhaus @Swiftb0y