Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast: fix wrapping arund pushbutton values #4001

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jun 15, 2021

the previous button combo had toggle and display connections, and the icon would get stuck in the 'failed' state because the number of display states doesn't match that of the toggle states.
one could not disabled broadcasting with the skin button (infinite, fail>enable>fail loop instead)

now that's separate stacked widgets.

@github-actions github-actions bot added the skins label Jun 15, 2021
@ronso0 ronso0 added this to In progress in 2.3 release via automation Jun 15, 2021
@ronso0 ronso0 added this to the 2.3.0 milestone Jun 15, 2021
@ronso0 ronso0 moved this from In progress to Needs Review in 2.3 release Jun 15, 2021
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem reasonable and safe, so let's give it a try. LGTM

@uklotzde uklotzde merged commit f7523bd into mixxxdj:2.3 Jun 16, 2021
2.3 release automation moved this from Needs Review to Done Jun 16, 2021
@ronso0 ronso0 deleted the broadcast-toggle branch June 16, 2021 21:22
@ronso0 ronso0 changed the title Broadcasting: fix wrapping arund pushbutton values Broadcast: fix wrapping arund pushbutton values Oct 29, 2021
@daschuer daschuer added broadcast Bugs pertaining to streaming radio broadcaster use-case and removed broadcasting labels Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Bugs pertaining to streaming radio broadcaster use-case skins
Projects
No open projects
2.3 release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants