Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QMLDemo: Add enum for specifing knob arc start position #4003

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

Swiftb0y
Copy link
Member

I wanted to experiment a bit with QML enums an figured this might be a good exercise resulting in slightly more expressive code.

@github-actions github-actions bot added the skins label Jun 15, 2021
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how do I let the Arc start at 3/4 now? ;-)

res/skins/QMLDemo/Mixxx/Controls/Knob.qml Outdated Show resolved Hide resolved
@Swiftb0y
Copy link
Member Author

But how do I let the Arc start at 3/4 now? ;-)

You can still just manually specify the arcStartValue ;)

@Swiftb0y Swiftb0y force-pushed the qml-improve-knob-dx branch 2 times, most recently from 3193dc0 to 78462de Compare June 16, 2021 06:55
@Holzhaus Holzhaus added this to In progress in QML GUI via automation Jun 16, 2021
@Swiftb0y
Copy link
Member Author

Ready

@Holzhaus Holzhaus merged commit de3bde2 into mixxxdj:main Jun 18, 2021
QML GUI automation moved this from In progress to Done Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants