Add preference option to set the row height #403
Conversation
|
Shouldn't column height be derived from the library font? I'd prefer to have a preference for a font choice. |
|
I'd really prefer we discuss design questions like this before you start writing code. It means you do a lot of extra work and these PRs are not a good interface for this type of design discussion. |
|
Basically, it is a good idea to allow to add some flexible whitespace around the text in a row. Hard to do in pure QSS, and can improve readability tremendously. Nonetheless your motivation was probably related to cover display.
While we at it: I'd prefer to have a extra preference for a font choice ;-) My only concern is that it has an negative impact on the, already not so brilliant, library performance because of the potential bigger cover display, as discussed in #403. |
|
I have tested this on my netbook and I have not noticed performance issues. It is probably because it is somehow self-compensating. As bigger covers are as less tracks can be displayed. This is fix for "add an option for a non chopped cover art to library table" |
|
BTW the word "column" is misspelled throughout the commit. |
| <number>10</number> | ||
| </property> | ||
| <property name="maximum"> | ||
| <number>50</number> |
There was a problem hiding this comment.
Commit message says "..up to 60". Typo?
If the height of cells is measured in pixel, please add a px suffix to the actual value.
|
The |
daschuer
changed the title
daschuer
changed the title
daschuer
force-pushed
the
cover_row_height
branch
from
d53da01
to
93e5315
Compare
|
Now it works! |
|
I would strongly prefer a font size choice that would drive the row height organically instead of a row height which won't change the library font size |
|
@ywwg a changeable font size is a different use case. |
|
Can you attach a screenshot of what this looks like? |
|
|
| @@ -37,7 +37,8 @@ WLibraryTableView::WLibraryTableView(QWidget* parent, | |||
| setHorizontalScrollMode(QAbstractItemView::ScrollPerPixel); | |||
|
|
|||
| verticalHeader()->hide(); | |||
| verticalHeader()->setDefaultSectionSize(20); | |||
| int coloumnHeight = m_pConfig->getValueString(ConfigKey("[Library]","RowHeight"), "20").toInt(); | |||
There was a problem hiding this comment.
Missed to renamecoloumnHeight here?
|
at least the text is centered. I guess it's ok |
|
Thank you @esbrandt for the extreme cases. Here my desired ones: |
|
Merge? |
|
I think you should address jus's comment about the spinbox prefix -- other On Wed, Nov 26, 2014, 3:24 PM Daniel Schürmann notifications@github.com
|
|
Oh, forgot that. Now it is place. Thank you for review. |
Add preference option to set the row height
This is useful to display big covers in the library table. Or to tweak the count of rows that fit on the screen.