SidebarModel: Add basic support for icon names #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
The icons are still there, and the code LGTM.
Unfortunately widows fails to build probably unrelated:
2021-06-28T21:22:26.9918997Z sccache: caused by: error reading compile response from server
2021-06-28T21:22:26.9919905Z sccache: caused by: Failed to read response header
2021-06-28T21:22:26.9920700Z sccache: caused by: An existing connection was forcibly closed by the remote host. (os error 10054)
2021-06-28T21:22:26.9921802Z [206/863] Building CXX object CMakeFiles\mixxx-lib.dir\src\engine\bufferscalers\enginebufferscalest.cpp.obj
2021-06-28T21:22:26.9923060Z FAILED: CMakeFiles/mixxx-lib.dir/src/engine/bufferscalers/enginebufferscalest.cpp.obj
shall I merge anyway?
|
I restarted the CI build to be sure. |
|
Are the Windows build issues unrelated? |
Are you referring to what @daschuer posted? Yes, that is unrelated. Sccache sometimes stops responding, causing the build to fail. |
|
I manually restarted the build and it worked 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QML can't deal with
QIconobjects. Instead, it uses icon urls. We could convert the qrc icon path to aqrc://url, but that would maintain the current limitation that the library icons can't be customized. Therefore, this only uses icon "names" and the QML part can build the icon url itself (potentially using custom icons).