EngineBuffer: Use mixxx::audio::FramePos for some methods #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
reviewed
Jul 7, 2021
src/engine/enginebuffer.cpp
Outdated
| queueNewPlaypos(position, seekType); | ||
| } | ||
|
|
||
| void EngineBuffer::doSeekPlayPos(double new_playpos, enum SeekRequest seekType) { |
There was a problem hiding this comment.
I suggest to rename this method explicitly to doSeekPlayPosLegacy/doSeekPlayPosSamples/doSeekPlaySamplePos(?) instead of using function overloading.
There was a problem hiding this comment.
I wanted to keep the changes in calling code to a minimum to reduce the size of the diff. Once we migrated all the engine control classes, we should just remove it.
There was a problem hiding this comment.
Nevermind, it's a private method. I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.