skins/QMLDemo: Add SyncButton component with leader support #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
reviewed
Jul 7, 2021
No wonder, I listened to this while coding https://www.youtube.com/watch?v=O_e5oYqNRSM ;-) |
Swiftb0y
approved these changes
Jul 7, 2021
There was a problem hiding this comment.
It's a bit ugly that the Sync button changes to the green sync text on press and then goes to implicit (orange leader) when released. It would look better if the text would only change once instead of twice, but thats polishing and can be done later. LGTM, I'll merge.
|
Thanks. @ywwg You can now use the qml skin for testing explicit leader ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.