Speed rename #409

daschuer · 2014-11-29T16:22:12Z

This fixes Bug https://bugs.launchpad.net/mixxx/+bug/1283190

…and Manual https://bugs.launchpad.net/mixxx/+bug/1283190

rryan · 2014-11-29T16:33:22Z

src/controllers/controlpickermenu.cpp

+                             tr("Adjust speed up (fine)"), speedMenu);
+    addDeckAndSamplerControl("rate_perm_down", tr("Speed Down"), tr("Adjust speed down (coarse)"), speedMenu);
+    addDeckAndSamplerControl("rate_perm_down_small", tr("Speed Down (Fine)"),
+                             tr("Adjust speed down (fine)"), speedMenu);
    addDeckAndSamplerControl("rate_temp_up", tr("Pitch-Bend Rate Up"),


Technically this ones a "speed bend" since in keylock mode it doesn't affect the pitch.

What about renaming it to "Speed Up (temporary / pitch-bend)"

Or
"Temporary Speed Up / Pitch Bend"
"Temporary Slow Down / Pitch Bend"
"Temporary Speed Up / Pitch Bend (Fine)"
"Temporary Slow Down / Pitch Bend (Fine)"

I have thought about it,and recognized that "Pitchbend" is a well defined term.
Do we have such a Pitchbend here?
From Mixxx view only, just Speed up without any "pitchbend" would be fine for me.

No, it is not exactly like a pitchband control you find on a keyboard. So lets ditch it.

Pitch-bend in the DJ context is different from the keyboard context -- there's precedent for calling pitch-bend / tempo-bend a button that increases/decreases the speed temporarily. On old turntables the pitch bend buttons ran the motor faster or slower. CDJs copied that but added master tempo and either still called them pitch bend or called them pitch/tempo bend.

We provide parenthetical / slashed text to give the user a hint for terminology they might be used to. An example is "headphone (pfl)" above so it may be useful to keep "pitch bend" in the string because people are used to calling this a pitch bend.

What about:
"Temporarily Increase Speed / Pitch Bend (coarse)"
"Temporarily Decrease Speed / Pitch Bend (coarse)"
"Temporarily Increase Speed / Pitch Bend (fine)"
"Temporarily Decrease Speed / Pitch Bend (fine)"

What about:
"Temporarily Increase Speed / Pitch Bend (coarse)"
"Temporarily Decrease Speed / Pitch Bend (coarse)"
"Temporarily Increase Speed / Pitch Bend (fine)"
"Temporarily Decrease Speed / Pitch Bend (fine)"

these sound good to me

ywwg · 2014-11-29T19:37:10Z

Tempo Up / Tempo Down?

ywwg · 2014-11-29T20:37:50Z

"Increase Speed" / "Decrease Speed"

daschuer · 2014-11-29T20:42:17Z

"Increase Speed" / "Decrease Speed"

Sounds good.

rryan · 2014-11-29T20:52:48Z

"Increase Speed" / "Decrease Speed"
Sounds good.

👍

daschuer · 2014-11-29T21:01:00Z

done

ywwg · 2014-11-29T21:11:55Z

src/controllers/controlpickermenu.cpp

-    // Rate
-    QMenu* rateMenu = addSubmenu(tr("Pitch and Rate"));
+    // Speed
+    QMenu* speedMenu = addSubmenu(tr("Speed (Pitch/Tempo)"));


how about "Speed (Tempo / Vinyl "Pitch")"

My logic was Speed changes Musical Pitch and Musical tempo.
Except Keylock is enabled. Then it changes only the musical tempo.
If we may have a tempolock, it changes only the pitch.
From this point of view the "Pitch" label on a Turntable is only a Short form of "Pitch and tempo".
Technically the should have lable it "Platter Speed".
This is a no issue on turntables, because the can't control Pitch and tempo independently, but it is important in Mixxx.
For the menu title, I would like to keep the current version. But it is a good idea to reference the turntable pitch slider in the description below.

daschuer · 2014-12-02T10:06:04Z

Notes addressed.

rryan · 2014-12-02T21:34:43Z

src/dlgprefcontrolsdlg.ui

@@ -506,7 +431,9 @@ Numark mode:
        <font/>
       </property>
       <property name="toolTip">
-        <string>Adjust the available range for the pitch (tempo) change controls.</string>


This one is kind of awkward in English. What about:

Adjusts the available range of the speed (Vinyl "Pitch") slider. If key-lock is disabled speed affects the pitch and tempo. If key-lock is enabled speed only affects the tempo.

Wait, this is the rate range slider. We shouldn't mention keylock at all.

Adjusts the range of the speed (Vinyl "Pitch") slider.

rryan · 2014-12-02T21:34:57Z

src/dlgprefcontrolsdlg.ui

-        <string>Adjust the available range for the pitch (tempo) change controls.</string>
+        <string>Adjust the available range for the speed (Vinyl &quot;Pitch&quot;) slider.  
+A Speed change of 6 % changes the pitch by one semitone, if key lock is disabled.
+If key lock is enabled, only the tempo is effected. </string>


effected -> affected

…ore %

daschuer · 2014-12-02T23:33:32Z

Notes addressed

rryan · 2014-12-02T23:43:51Z

Looks good -- but why the spaces between the percent symbol and the number?

daschuer · 2014-12-03T00:02:25Z

It is a international standard ISO 31-0 ;-)

Speed rename

ywwg · 2014-12-03T00:16:54Z

space before percent is stupid. reverting it

rryan · 2014-12-03T03:01:32Z

Hard to put it more delicately than @ywwg said.

I think it's not that common -- definitely looks odd to me. Let's leave it as it was.

Some debate on the topic:
http://english.stackexchange.com/questions/3281/should-there-be-a-space-before-a-percent-sign

jgehrcke · 2014-12-03T16:10:16Z

My two cents: maybe there is some controversy, but the space is not stupid at all. As a physicist, I am of the opinion that the space is a must, according to what is quoted in named SE thread:

This is in accordance with the general rule of adding a non-breaking space
between a numerical value and its corresponding unit of measurement.

Seeing both worlds, I think one can summarize: without space is more colloquial, with space is more scientific. It is up to you which style to choose from :-).

daschuer · 2014-12-03T16:20:40Z

Hi @jgehrcke,

It seams that the German and ISO style is with space and the English style is without.
Since we can translate "%" to " %" it should be no issue.

jgehrcke · 2014-12-03T16:26:55Z

@daschuer, pretty sure that this question is no matter of German vs. English. Really, I am convinced that its is a question of colloquial vs. scientific language. I had this discussion with Germans, too, already (there are many Germans that do not want to use a space there). In scientific publications written in English there definitely is a preference for using a space. That is also why "the TeX typesetting system encourages using one". But hey, this discussion ends up being philosophical anyway. Of course, I'd rather see Mixxx taking the scientific approach, but this really is not too important :-).

ywwg · 2014-12-03T16:27:53Z

If someone wants to put a space in front in the german translation, I'm not going to notice :)

daschuer added 4 commits November 29, 2014 16:36

Introduce Speed instead of Pitch/Rate, to match other place in Mixxx …

d57b778

…and Manual https://bugs.launchpad.net/mixxx/+bug/1283190

User Speed term for combined Pitch/Tempo control in ControlPickerMenu

8893001

Fix some var names and comments to Speed = Pitch / Tempo

28d1f3a

removed unused getPitchIndpTimeStretch()

cad57a3

rryan reviewed Nov 29, 2014
View reviewed changes

daschuer added 2 commits November 29, 2014 21:46

Playback Speed without Slider

713705e

Increase/Decrease Speed

4d6ee04

replace pitch-bend with Temporary Increase/Decrease Speed

bc2a846

ywwg reviewed Nov 29, 2014
View reviewed changes

daschuer added 3 commits December 1, 2014 19:54

Add a (Vinyl "Pitch" slider) hint

e7c3d89

Temporary -> Temporarily Up -> faster down -> slower

e2bbb9c

Improved tooltip of the Speed Range combobox

5208f16

daschuer force-pushed the speed_rename branch from 09aad40 to 5208f16 Compare December 2, 2014 10:04

rryan reviewed Dec 2, 2014
View reviewed changes

daschuer added 2 commits December 3, 2014 00:20

Added Adjustment to the group box headers

b49acb7

Removed key and tempo related parts of speed tooltip, Edded space bef…

73ff7e0

…ore %

daschuer added a commit that referenced this pull request Dec 3, 2014

Merge pull request #409 from daschuer/speed_rename

b8708c6

Speed rename

daschuer merged commit b8708c6 into mixxxdj:master Dec 3, 2014

daschuer deleted the speed_rename branch December 6, 2014 23:57

mixxxbot mentioned this pull request Aug 22, 2022

Use "Speed" for all terms relatedt to the rate CO #7322

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Speed rename #409

Speed rename #409

daschuer commented Nov 29, 2014

rryan Nov 29, 2014

rryan Nov 29, 2014

daschuer Nov 29, 2014

daschuer Nov 29, 2014

rryan Nov 29, 2014

ywwg Nov 29, 2014

ywwg commented Nov 29, 2014

ywwg commented Nov 29, 2014

daschuer commented Nov 29, 2014

rryan commented Nov 29, 2014

daschuer commented Nov 29, 2014

ywwg Nov 29, 2014

daschuer Nov 29, 2014

daschuer commented Dec 2, 2014

rryan Dec 2, 2014

rryan Dec 2, 2014

rryan Dec 2, 2014

daschuer commented Dec 2, 2014

rryan commented Dec 2, 2014

daschuer commented Dec 3, 2014

ywwg commented Dec 3, 2014

rryan commented Dec 3, 2014

jgehrcke commented Dec 3, 2014

daschuer commented Dec 3, 2014

jgehrcke commented Dec 3, 2014

ywwg commented Dec 3, 2014

Speed rename #409

Speed rename #409

Conversation

daschuer commented Nov 29, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ywwg commented Nov 29, 2014

ywwg commented Nov 29, 2014

daschuer commented Nov 29, 2014

rryan commented Nov 29, 2014

daschuer commented Nov 29, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daschuer commented Dec 2, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daschuer commented Dec 2, 2014

rryan commented Dec 2, 2014

daschuer commented Dec 3, 2014

ywwg commented Dec 3, 2014

rryan commented Dec 3, 2014

jgehrcke commented Dec 3, 2014

daschuer commented Dec 3, 2014

jgehrcke commented Dec 3, 2014

ywwg commented Dec 3, 2014