Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beats: Fix outdated comment #4104

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Beats: Fix outdated comment #4104

merged 1 commit into from
Jul 12, 2021

Conversation

Holzhaus
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1024429773

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 28.642%
Files with Coverage Reduction New Missed Lines %
src/engine/enginevumeter.cpp 1 90.24%
Totals Coverage Status
Change from base Build 1023749434: -0.001%
Covered Lines: 20098
Relevant Lines: 70170
💛 - Coveralls

uklotzde
uklotzde approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 193b01e into mixxxdj:main Jul 12, 2021
@Holzhaus Holzhaus added this to In Progress in Semanting Type Refactoring via automation Jul 13, 2021
@Holzhaus Holzhaus added this to In progress in Beats Refactoring via automation Jul 13, 2021
@Holzhaus Holzhaus moved this from In Progress to Done in Semanting Type Refactoring Aug 16, 2021
@Holzhaus Holzhaus moved this from In progress to Done in Beats Refactoring Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
code quality
Projects
Beats Refactoring
Status: Done
Semanting Type Refactoring
Status: Done
Beats Refactoring
Done
Semanting Type Refactoring
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Holzhaus @coveralls @uklotzde