Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HotcueControlTest: Use mixxx::FramePos type #4105

Merged
merged 3 commits into from
Jul 27, 2021
Merged

HotcueControlTest: Use mixxx::FramePos type #4105

merged 3 commits into from
Jul 27, 2021

Conversation

Holzhaus
Copy link
Member

No description provided.

@Holzhaus Holzhaus added this to In Progress in Semanting Type Refactoring via automation Jul 15, 2021
@coveralls
Copy link

coveralls commented Jul 15, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1057489686

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.629%
Totals Coverage Status
Change from base Build 1056746152: 0.0%
Covered Lines: 20098
Relevant Lines: 70202
💛 - Coveralls

@Holzhaus
Copy link
Member Author

Holzhaus commented Jul 22, 2021 •
edited
Loading

Merge conflicts resolved, ready to merge again.

@Holzhaus Holzhaus requested a review from uklotzde July 26, 2021 15:59
uklotzde
uklotzde approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit f8aab67 into mixxxdj:main Jul 27, 2021
Semanting Type Refactoring automation moved this from In Progress to Done Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
code quality
Projects
Semanting Type Refactoring
Status: Done
Semanting Type Refactoring
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Holzhaus @coveralls @uklotzde