Numark DJ2GO2 Touch mapping #4108
Conversation
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
|
Also, in the future, make a feature branch when implementing new features such as a controller mapping otherwise you might get into trouble with git later. This was outlined here: https://github.com/mixxxdj/mixxx/wiki/Contributing-Mappings#setting-up-git |
|
I managed to fix the encoder issues :) completely mapped now. |
| // create an instance of your custom Deck object for each side of your controller | ||
| DJ2GO2Touch.leftDeck = new DJ2GO2Touch.Deck([1], 0); | ||
| DJ2GO2Touch.rightDeck = new DJ2GO2Touch.Deck([2], 1); | ||
| }; |
There was a problem hiding this comment.
| }; | |
| midi.sendSysexMsg([0xF0, 0x00, 0x20, 0x7F, 0x03, 0x01, 0xF7], 0); | |
| }; |
Not sure if your controller supports it, but if you add this, your controller should send the values of all of its controls. This way, Mixxx should be instantly synced with the controlled when the mapping was loaded.
There was a problem hiding this comment.
I just tried adding this, it didnt seem to make a difference, is there anything I should look out for in the controller debug output?
There was a problem hiding this comment.
Debug [Controller]: DJ2GO2 Touch MIDI 1: outgoing: status 0x95 (ch 6, opcode 0x9), ctrl 0x23, val 0x00
Debug [Controller]: DJ2GO2 Touch MIDI 1: outgoing: 7 byte sysex: [F0 00 20 7F 03 01 F7]
Debug [Controller]: DJ2GO2 Touch MIDI 1: outgoing: status 0x94 (ch 5, opcode 0x9), ctrl 0x33, val 0x7F
Debug [Controller]: DJ2GO2 Touch MIDI 1: outgoing: status 0x94 (ch 5, opcode 0x9), ctrl 0x34, val 0x7F
Debug [Controller]: DJ2GO2 Touch MIDI 1: outgoing: status 0x94 (ch 5, opcode 0x9), ctrl 0x35, val 0x7F
I spotted it, but not sure ...
There was a problem hiding this comment.
The controller should usually respond with a bunch of messages. We have a wiki page on this if you need more context: https://github.com/mixxxdj/mixxx/wiki/serato_sysex
There was a problem hiding this comment.
I understand now, it mostly works, the faders are accurate to their state on the controller, potentiometers aren't though, I'll commit that now.
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
Please note that we require a corresponding, finished documentation PR for the mixxxdj/manual repo before we can merge. |
|
I made a PR for my manual entry :) |
|
@tandy-1000 thanks for your work. |
|
Done |
|
Thanks |
|
Give me some time to take a final look before merging. Thanks. |
@tandy-1000 was quite responsive and fixed all issues pointed out during review quickly. Considering that the manual PR was already merged, I suppose we can merge now and if we find more issues, these can be taken care of in a separate PR. Ideally we should merge the mapping and the manual page at the same time. Now its a bit confusing that the manual already lists the mapping as "added in 2.3.1" but its actually missing. |
|
Thank you everyone for the support in getting this merged, I didn't expect to be able to do it but it was possible with everyone's help :) Mixxx is a great piece of software and I am happy to have been able to contribute. |
|
@Swiftb0y Next time please squash the commits before merging. |
|
...especially controller mapping branches are often a bit messy with lots of back and forth commits and unhelpful commit messages. |
I wrote a components.js mapping with help from @Holzhaus , @Swiftb0y , and others on the Zulip.
All functionality that I know of is available, however the browse encoder functionality still has some work to be done.