Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferences: Remove all references to MixxxMainWindow #4109

Merged
merged 6 commits into from Jul 21, 2021
Merged

Preferences: Remove all references to MixxxMainWindow #4109

merged 6 commits into from Jul 21, 2021

Commits on Jul 16, 2021

  1. MixxxMainWindow: Move screensaver inhibitor code into CoreServices

    @Holzhaus
    Holzhaus committed Jul 16, 2021
    Copy the full SHA
    6cf0118 View commit details
    Browse the repository at this point in the history

  2. DlgPrefInterface: Acquire primary screen for QGuiApplication 

    We can't have any references to the `MixxxMainWindow` class in
`DlgPrefInterface` if we want to use the preferences for QML skins that
don't have a `MixxxMainWindow` instance. The using the primary screen is
a sensible fallback.
    @Holzhaus
    Holzhaus committed Jul 16, 2021
    Copy the full SHA
    b4e9055 View commit details
    Browse the repository at this point in the history

  3. MixxxMainWindow: Move tooltip mode setting into preferences 

    Instead of letting the `DlgPrefInterface` class hold a reference to the
`MixxxMainWindow` and call its `setToolTipsCfg` method directly, we just
update the config object and emit a signal that the main window can
connect to.
    @Holzhaus
    Holzhaus committed Jul 16, 2021
    Copy the full SHA
    b0e0a32 View commit details
    Browse the repository at this point in the history

  4. DlgPreferences: Use signals to request skin reload 

    Instead of calling `rebootMixxxView` directly, we can just emit a
signal. This allows removing any references to the `MixxxMainWindow` in
`DlgPreferences`.
    @Holzhaus
    Holzhaus committed Jul 16, 2021
    Copy the full SHA
    ccf6bb2 View commit details
    Browse the repository at this point in the history

  5. DlgPrefWaveform: Use signal to request reload of user interface 

    This is similar to the previous commit, it basically removes the
necessity to hold a pointer to the main window.
    @Holzhaus
    Holzhaus committed Jul 16, 2021
    Copy the full SHA
    405e165 View commit details
    Browse the repository at this point in the history

  6. DlgPreferences: Remove all references to MixxxMainWindow

    @Holzhaus
    Holzhaus committed Jul 16, 2021
    Copy the full SHA
    f1a5780 View commit details
    Browse the repository at this point in the history