Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: only check for Upower if BATTERY=ON #4113

Merged
merged 1 commit into from
Jul 18, 2021
Merged

CMake: only check for Upower if BATTERY=ON #4113

merged 1 commit into from
Jul 18, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jul 17, 2021

Upower might not be available on all systems:
alpinelinux/aports@27abfa3#r53627806

Be-ing referenced this pull request in alpinelinux/aports Jul 17, 2021
@PureTryOut
testing/mixxx: disable on riscv64
27abfa3
@github-actions github-actions bot added the build label Jul 17, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1041240096

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 28.641%
Files with Coverage Reduction New Missed Lines %
src/engine/cachingreader/cachingreaderworker.cpp 2 63.48%
Totals Coverage Status
Change from base Build 1040577215: -0.001%
Covered Lines: 20097
Relevant Lines: 70168
💛 - Coveralls

uklotzde
uklotzde approved these changes Jul 18, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit to me.

@Holzhaus?

@Holzhaus
Copy link
Member

Look legit, didn't test myself, but two people approved already. I'm merging this.

@Holzhaus Holzhaus merged commit 7854637 into mixxxdj:main Jul 18, 2021
@Be-ing Be-ing deleted the upower_check branch July 18, 2021 17:25
@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 18, 2021

Whoops this was targeted to main. Cherry pick it to 2.3?

@Holzhaus
Copy link
Member

Please use git cherry pick and open a new PR. I'd like to have CI confirmation for point releases

@Be-ing Be-ing mentioned this pull request Jul 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Be-ing @coveralls @Holzhaus @uklotzde @daschuer