Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More warning fixes #4118

Merged
merged 5 commits into from
Jul 19, 2021
Merged

More warning fixes #4118

merged 5 commits into from
Jul 19, 2021

Conversation

daschuer
Copy link
Member

to fix a warning with macOs

@coveralls
Copy link

coveralls commented Jul 18, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1043368336

  • 2 of 3 (66.67%) changed or added relevant lines in 3 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 28.631%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/encoder/encoderopus.cpp 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/engine/cachingreader/cachingreader.cpp 10 71.38%
Totals Coverage Status
Change from base Build 1042849443: -0.01%
Covered Lines: 20090
Relevant Lines: 70168
💛 - Coveralls

@daschuer
Copy link
Member Author

I have removed some more trivial warnings.

@daschuer daschuer changed the title removed unused pConfig parameter More warning fixes Jul 19, 2021
uklotzde
uklotzde approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 69a4193 into mixxxdj:main Jul 19, 2021
@daschuer daschuer deleted the unused_warning branch September 26, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
library ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daschuer @coveralls @uklotzde