Echo fix: echo added left channel samples to right channel #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah the PR is messed up because it also contains the trans effect... |
|
Welcome and thanks for contributing to Mixxx. As a first-time contributor we need you to sign our Contributor Agreement. Then comment here when done. The echo effect fix should go into 2.3.1. Please rebase this branch on the 2.3 branch and remove the unrelated commits. Force push your branch to update the PR and then change the target branch from main to 2.3. |
uklotzde
suggested changes
Jul 24, 2021
uklotzde
approved these changes
Jul 24, 2021
|
For future contributions please read The seven rules of a great Git commit message I would have probably written: "Echo effect: Feed back samples from left/right instead of only left channel" |
|
Good catch! Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes what is likely a copy-paste error. Or I completely misread the code. Please review.
(I did not check the rest of the code, the ping-pong cod is not symmetric either but that might be fine.)