Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Houskeeping for MixxxMainWindow #4178

Merged
merged 3 commits into from
Aug 5, 2021
Merged

Houskeeping for MixxxMainWindow #4178

merged 3 commits into from
Aug 5, 2021

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Aug 5, 2021

No description provided.

@uklotzde uklotzde requested a review from Holzhaus August 5, 2021 00:20
@coveralls
Copy link

coveralls commented Aug 5, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1099669357

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 26.012%
Files with Coverage Reduction New Missed Lines %
src/engine/readaheadmanager.cpp 2 88.79%
Totals Coverage Status
Change from base Build 1099453988: -0.001%
Covered Lines: 20007
Relevant Lines: 76914
💛 - Coveralls

Be-ing
Be-ing approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for requested review from @Holzhaus

@Holzhaus Holzhaus merged commit bf9ed9f into mixxxdj:main Aug 5, 2021
@uklotzde uklotzde deleted the mixxxmainwindow branch August 5, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

@Be-ing Be-ing Be-ing approved these changes

Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uklotzde @coveralls @Holzhaus @Be-ing