Beats: Implement setBpm() for BeatMaps and remove capabilities #4184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
reviewed
Aug 8, 2021
src/track/beats.h
Outdated
| /// TODO: This is only needed for the "Asumme Constant Tempo" checkbox in | ||
| /// `DlgTrackInfo`. This should probably be removed or reimplemented to | ||
| /// check if all neighboring beats in this object have the same distance. | ||
| virtual bool isConst() const = 0; |
There was a problem hiding this comment.
has/isConstantTempo()? I would prefer to be more explicit here.
For now, BeatMap::setBpm() will simply return a const BeatGrid object with the desired BPM, starting at the first beat of the BeatMap. In the future, both Beats classes should be merged.
Holzhaus
force-pushed
the
beatmap-setbpm
branch
from
5e8b560
to
3beef8f
Compare
Pull Request Test Coverage Report for Build 1110006044
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.