Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EngineControl: Use mixxx::audio::FramePos #4186

Merged
merged 7 commits into from Aug 10, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Aug 6, 2021

Some work towards using frame positions in the engine.

@Holzhaus Holzhaus added the engine label Aug 6, 2021
@Holzhaus Holzhaus added this to In Progress in Semanting Type Refactoring via automation Aug 6, 2021
@coveralls
Copy link

coveralls commented Aug 6, 2021

Pull Request Test Coverage Report for Build 1117774890

  • 94 of 153 (61.44%) changed or added relevant lines in 11 files are covered.
  • 998 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.0003%) to 25.998%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/engine/controls/enginecontrol.cpp 9 11 81.82%
src/engine/positionscratchcontroller.cpp 0 3 0.0%
src/engine/controls/bpmcontrol.cpp 6 10 60.0%
src/engine/controls/loopingcontrol.cpp 30 36 83.33%
src/engine/controls/vinylcontrolcontrol.cpp 0 7 0.0%
src/engine/controls/cuecontrol.cpp 30 67 44.78%
Files with Coverage Reduction New Missed Lines %
src/engine/controls/cuecontrol.cpp 1 68.94%
src/engine/controls/loopingcontrol.cpp 1 82.97%
src/engine/controls/vinylcontrolcontrol.cpp 1 50.46%
src/engine/sync/internalclock.h 1 80.0%
src/track/beatgrid.h 2 60.0%
src/util/db/dbconnection.cpp 5 69.78%
src/engine/sync/internalclock.cpp 16 80.51%
src/library/dao/directorydao.cpp 17 75.61%
src/engine/sync/synccontrol.cpp 38 82.46%
src/engine/sync/enginesync.cpp 44 85.11%
Totals Coverage Status
Change from base Build 1104640684: 0.0003%
Covered Lines: 20015
Relevant Lines: 76988

💛 - Coveralls

@Holzhaus
Copy link
Member Author

Holzhaus commented Aug 6, 2021

Let me know if the diff is too big, I can cherry pick individual commits into separate branches if you want.

src/engine/controls/cuecontrol.cpp Show resolved Hide resolved
src/engine/controls/enginecontrol.cpp Outdated Show resolved Hide resolved
src/engine/controls/enginecontrol.h Show resolved Hide resolved
src/engine/controls/vinylcontrolcontrol.cpp Show resolved Hide resolved
src/engine/positionscratchcontroller.cpp Show resolved Hide resolved
@uklotzde
Copy link
Contributor

LGTM, waiting for CI

@uklotzde
Copy link
Contributor

CI failure is unrelated.

@uklotzde uklotzde merged commit 8a2deba into mixxxdj:main Aug 10, 2021
Semanting Type Refactoring automation moved this from In Progress to Done Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants