Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit config #4192

Merged
merged 4 commits into from
Aug 16, 2021
Merged

Update pre-commit config #4192

merged 4 commits into from
Aug 16, 2021

Conversation

uklotzde
Copy link
Contributor

pre-commit autoupdate

@coveralls
Copy link

coveralls commented Aug 10, 2021

Pull Request Test Coverage Report for Build 1127045423

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 362 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.03%) to 25.982%

Files with Coverage Reduction New Missed Lines %
src/engine/readaheadmanager.cpp 2 88.89%
src/engine/enginebuffer.cpp 4 86.38%
src/engine/cachingreader/cachingreader.cpp 9 71.38%
src/engine/controls/clockcontrol.cpp 17 72.48%
src/library/trackset/baseplaylistfeature.cpp 157 0%
src/library/trackset/crate/cratefeature.cpp 173 0%
Totals Coverage Status
Change from base Build 1117978159: -0.03%
Covered Lines: 20004
Relevant Lines: 76991

💛 - Coveralls

@Holzhaus
Copy link
Member

Thanks.

The checks on this PR only run pre-commit against the diff, so only the YAML file is checked. For example, when black is updated the formatting rules may slightly change and cause reformattings in our python files.

Did you run this locally with the command line we use on CI to verify that this is not the case?

@uklotzde
Copy link
Contributor Author

No changes: SKIP=end-of-file-fixer,trailing-whitespace,clang-format,eslint,no-commit-to-branch pre-commit run --all-files

@uklotzde uklotzde mentioned this pull request Aug 13, 2021
2 tasks
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Holzhaus
Copy link
Member

Holzhaus commented Aug 15, 2021

Should we backport this to 2.3? It won't make a difference for the user but we avoid introducing code with wrong formatting/typos in a 2.3.x release that causes problems when we merge 2.3 into main.

@uklotzde uklotzde changed the base branch from main to 2.3 August 15, 2021 10:04
@uklotzde
Copy link
Contributor Author

Rebased onto 2.3

@Holzhaus Holzhaus merged commit 3f1f81d into mixxxdj:2.3 Aug 16, 2021
@uklotzde uklotzde deleted the pre-commit branch August 16, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants