Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlists & Crates: Store selected TrackId instead of TrackPointer #4194

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Playlists & Crates: Store selected TrackId instead of TrackPointer #4194

merged 1 commit into from
Aug 12, 2021

Conversation

uklotzde
Copy link
Contributor

...to avoid delays when exporting file tags.

Another low-hanging fruit. See also: https://mixxx.discourse.group/t/tag-export-question-2-3-0/22822

@coveralls
Copy link

coveralls commented Aug 11, 2021

Pull Request Test Coverage Report for Build 1121569811

  • 0 of 21 (0.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.004%) to 26.004%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/library/trackset/baseplaylistfeature.cpp 0 8 0.0%
src/library/trackset/crate/cratefeature.cpp 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
src/library/trackset/baseplaylistfeature.cpp 1 0%
src/library/trackset/crate/cratefeature.cpp 1 0%
src/engine/cachingreader/cachingreaderworker.cpp 2 63.48%
src/engine/readaheadmanager.cpp 2 88.89%
Totals Coverage Status
Change from base Build 1117978159: -0.004%
Covered Lines: 20021
Relevant Lines: 76991

💛 - Coveralls

...to avoid delays when exporting file tags.
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEGT, thank you.

@daschuer daschuer merged commit 48fb24d into mixxxdj:main Aug 12, 2021
@uklotzde uklotzde deleted the dont-store-selected-track-pointers branch August 12, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants