Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix waveform concurrency issues. Possible fix for Bug #1383404 #420

Merged
merged 3 commits into from
Dec 4, 2014
Merged

Fix waveform concurrency issues. Possible fix for Bug #1383404 #420

merged 3 commits into from
Dec 4, 2014

Commits on Dec 4, 2014

  1. Fix waveform concurrency issues. Potentially fixes Bug #1383404. 

    * Use const shared pointers for waveforms.
* Move all std::vector sizing operations to the Waveform constructor. No
  vector state is allowed to change after the constructor finishes.
* Clarify comments.
* Remove waveform mutex usage in WOverview variants.
* Use the track's waveform pointer to atomically swap the waveform
  rather than mutating the waveform in place.
* Remove unused code.
    @rryan
    rryan committed Dec 4, 2014
    Configuration menu
    Copy the full SHA
    4ca69a4 View commit details
    Browse the repository at this point in the history

  2. Review comments.

    @rryan
    rryan committed Dec 4, 2014
    Configuration menu
    Copy the full SHA
    a61a72b View commit details
    Browse the repository at this point in the history

  3. More review comments.

    @rryan
    rryan committed Dec 4, 2014
    Configuration menu
    Copy the full SHA
    bad8917 View commit details
    Browse the repository at this point in the history