Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devendor libebur128 #4202

Merged
merged 1 commit into from
Sep 30, 2021
Merged

devendor libebur128 #4202

merged 1 commit into from
Sep 30, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Aug 14, 2021

Why was this vendored in the first place?

@github-actions github-actions bot added the build label Aug 14, 2021
@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 14, 2021

I guess we don't have libebur128 in the macOS build environment. Let's remove this after switching to vcpkg for macOS.

@Be-ing Be-ing marked this pull request as draft August 14, 2021 23:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1131450830

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 25.997%
Totals Coverage Status
Change from base Build 1127725238: 0.01%
Covered Lines: 20015
Relevant Lines: 76991
💛 - Coveralls

@daschuer
Copy link
Member

It was originally introduced here:
#520
Because it was not part of Ubuntu Trusty.
Now our olldes supported Version Ubuntu Groovy (20.10) has 1.2.4-2

@Holzhaus
Copy link
Member

Why was this vendored in the first place?

I suppose we should a comment to CMakeLists.txt for every new dependency we add to the lib directory that explains why we added it.

@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 15, 2021

Unfortunately this let us get away with being lazy with maintaining our macOS build environment because we never added libebur128 to it. Let's merge this after switching macOS to vcpkg.

@Be-ing Be-ing marked this pull request as ready for review September 30, 2021 06:17
daschuer
daschuer approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green. LGTM. Thank you.

@daschuer daschuer merged commit 19e952b into mixxxdj:main Sep 30, 2021
@Be-ing Be-ing deleted the devendor_libebur128 branch September 30, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Be-ing @coveralls @daschuer @Holzhaus