Move code from Track to TrackDAO / Fix DB mapping #4214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
changed the title
Pull Request Test Coverage Report for Build 1139441457
💛 - Coveralls |
daschuer
requested changes
Aug 17, 2021
src/library/dao/trackdao.h
Outdated
| @@ -82,6 +83,10 @@ class TrackDAO : public QObject, public virtual DAO, public virtual GlobalTrackC | |||
|
|
|||
| /// Ugly workaround, don't use!!! | |||
| static void setTrackGenreInternal(Track* pTrack, const QString& genre); | |||
| /// Ugly workaround, don't use!!! | |||
There was a problem hiding this comment.
More than expected. Thank you.
daschuer
approved these changes
Aug 17, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cleanup PR before introducing a new file tag synchronization feature:
Track: MakesetHeaderParsedFromTrackDAO()private by moving the ugly workarounds as public methods intoTrackDAO, which is used by less code and where it does not matter so much.TrackDAO: Fix writing of theheader_parsedcolumn by populating it directly from the corresponding (deprecated) property. This was not a bug, just a conceptual issue. The effect is identical.