Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoopingControlTest: Fix wrong usage of FramePos for beatloop size CO #4232

Merged
merged 1 commit into from
Aug 19, 2021
Merged

LoopingControlTest: Fix wrong usage of FramePos for beatloop size CO #4232

merged 1 commit into from
Aug 19, 2021

Conversation

Holzhaus
Copy link
Member

This was accidently introduced by commit
3340c47.

@Holzhaus Holzhaus added this to In Progress in Semanting Type Refactoring via automation Aug 19, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1146804839

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 25.96%
Totals Coverage Status
Change from base Build 1146568621: 0.005%
Covered Lines: 20002
Relevant Lines: 77049
💛 - Coveralls

uklotzde
uklotzde approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Unfortunately, I have no idea how to prevent those semantic errors.

@uklotzde uklotzde merged commit 0efa809 into mixxxdj:main Aug 19, 2021
Semanting Type Refactoring automation moved this from In Progress to Done Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
code quality minor bug
Projects
Semanting Type Refactoring
Status: Done
Semanting Type Refactoring
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Holzhaus @coveralls @uklotzde