do not allow using keyboards and mice as HID controllers #4243

Be-ing · 2021-08-25T05:39:37Z

Enabling a keyboard or mouse as an HID controller makes it stop
working as a keyboard or mouse.

Enabling a keyboard or mouse as an HID controller makes it stop working as a keyboard or mouse.

daschuer

I think we have an exotic use case to use a second mouse for scratching. Can we preserve this without recompileing?

The root case for the linked issues seems that the mouse was enabled by default, the user setting was not persistent.

For my feeling this is the issue we should solve. Otherwise we need to Handel every single other issue of this type in our code base.

daschuer · 2021-08-25T06:10:07Z

src/controllers/hid/hidcontroller.cpp

@@ -151,10 +151,8 @@ void HidController::guessDeviceCategory() {
    if (hid_interface_number==-1) {
        if (hid_usage_page==0x1) {
            switch (hid_usage) {
-                case 0x2: info = tr("Generic HID Mouse"); break;


This change seem to be unrelated.
Now it runs to the default branch which is less describtive.

These devices do not appear in the GUI because they are filtered out in HidEnumerator.

daschuer · 2021-08-25T06:11:54Z

src/controllers/hid/hidenumerator.cpp

+            (device_info.usage == kGenericDesktopMouseUsage ||
+                    device_info.usage == kGenericDesktopKeyboardUsage)) {
+        return false;
+    }


Can we move this to the default deny list instead?
That would be the natural place.

I tried that at first but the backwards logic made it really confusing. I think this implementation is more straightforward. First there is this check for all mice and keyboards, then the denlylist is used to filter specific device models.

Be-ing · 2021-08-25T06:50:38Z

I think we have an exotic use case to use a second mouse for scratching. Can we preserve this without recompileing?

I don't really care. That user can comment out this code and recompile. I could even comment out the code myself, push it to a branch on GitHub, and the user could download the artifact. I am much more concerned about users accidentally getting their computer (not just Mixxx!) into an unusable state, which is much more common than exotic questionably useful hacks. https://bugs.launchpad.net/mixxx/+bug/1940599 is not the first time that has happened (I do not recall where a user has asked for help for this before, but I am pretty sure it has happened).

If there was no downside to letting users treat mice and keyboards as HID DJ controllers, then yeah it'd be nice to let them do so. But the downside is that some users will get their computer into an unusable state and (rightfully IMO) blame Mixxx.

Be-ing · 2021-08-25T06:51:51Z

The root case for the linked issues seems that the mouse was enabled by default, the user setting was not persistent.

That is a separate issue solved in #4244. The user who reported the bug was affected by both.

Ok, but not tested.

daschuer · 2021-08-25T12:05:52Z

Is this really something we should change in 2.3?
I don't think so.
The understanding bug that the mouse is enabled unwanted should be sufficient for the stable version.
Is the issue a regression from the change to hidraw?

Be-ing · 2021-08-25T14:29:08Z

Is this really something we should change in 2.3?

Yes, this is a critical bug. The user can get their computer into an entirely unusable state so they have to restart it.

Is the issue a regression from the change to hidraw?

No, that is unrelated.

Holzhaus · 2021-08-25T15:17:16Z

It's not a regression from hidraw. I have a Ducky mecha mini keyboard which shows up as a HID controller and stopped working when I enabled it in the Mixxx preferences on 2.3.

uklotzde

I am still not convinced of the scattered logic. But everything is well documented and we can't rewrite it for 2.3. Works for me.

uklotzde · 2021-08-27T18:30:59Z

Any objections? Otherwise let's merge.

Be-ing · 2021-08-31T07:35:17Z

ping

uklotzde · 2021-09-01T20:44:25Z

I interpret the lack of responses as silent approval. LGTM

I will take care of merging into main. Already did this for testing, should not be difficult.

uklotzde · 2021-09-01T21:13:38Z

Done. The constants have landed in hiddevice.h where they belong to instead of in hiddenylist.h.

Holzhaus · 2021-09-01T22:41:18Z

Btw, I can confirm that my laptops built-in touchpad doesn't show up anymore. 👍

foss- · 2021-09-02T09:13:47Z

2.4-alpha-785-g705a39070b (main), Thursday, September 2, 2021 12:43:40 AM CEST
On macOS internal keyboard / trackpad is still shown. Fun fact: the T1 security chip is also shown under controllers. And while it would be very geeky run doom or mixxx on a T1 I am not sure it is a good controller to offer to users. The magic trackpad listed is the external trackpad.

uklotzde · 2021-09-02T09:23:13Z

Please attach the enumerated HID devices from the log file.

foss- · 2021-09-02T10:21:55Z

Info [Controller] Scanning USB HID devices
Info [Controller] Found HID device: { 004c:0265 r0 | Usage: ff00:000b | Manufacturer: Apple | Product: Magic Trackpad 2 | S/N: XXX }
Info [Controller] Duplicate HID device, excluding { 004c:0265 r0 | Usage: ff00:0014 | Manufacturer: Apple | Product: Magic Trackpad 2 | S/N: XXX }
Info [Controller] Found HID device: { 05ac:0278 r896 | Usage: ff00:0003 | Interface: #4 | Product: Apple Internal Keyboard / Trackpad }
Info [Controller] Found HID device: { 004c:0265 r0 | Usage: ff00:0003 | Manufacturer: Apple | Product: Magic Trackpad 2 | S/N: XXX }
Info [Controller] Found HID device: { 05ac:0278 r0 | Usage: ff00:000f | Product: Keyboard Backlight }
Info [Controller] Excluding HID device { 05ac:0278 r896 | Usage: 0001:0002 | Product: Apple Internal Keyboard / Trackpad }
Info [Controller] Duplicate HID device, excluding { 05ac:0278 r896 | Usage: 0001:0001 | Product: Apple Internal Keyboard / Trackpad }
Info [Controller] Duplicate HID device, excluding { 05ac:0278 r896 | Usage: 000d:0005 | Product: Apple Internal Keyboard / Trackpad }
Info [Controller] Duplicate HID device, excluding { 05ac:0278 r896 | Usage: ff00:000c | Product: Apple Internal Keyboard / Trackpad }
Info [Controller] Found HID device: { 05ac:8600 r101 | Usage: 000d:0005 | Interface: #2 | Manufacturer: Apple Inc. | Product: Apple T1 Controller }
Info [Controller] Duplicate HID device, excluding { 05ac:8600 r101 | Usage: ff00:0023 | Interface: #2 | Manufacturer: Apple Inc. | Product: Apple T1 Controller }
Info [Controller] Duplicate HID device, excluding { 05ac:8600 r101 | Usage: ff00:0016 | Interface: #2 | Manufacturer: Apple Inc. | Product: Apple T1 Controller }
Info [Controller] Duplicate HID device, excluding { 05ac:8600 r0 | Usage: 0001:0006 | Product: TouchBarUserDevice }
Info [Controller] Found HID device: { 05ac:8600 r101 | Usage: 0020:0041 | Interface: #6 | Manufacturer: Apple Inc. | Product: Apple T1 Controller }
Info [Controller] Duplicate HID device, excluding { 05ac:8600 r101 | Usage: ff12:0001 | Interface: #6 | Manufacturer: Apple Inc. | Product: Apple T1 Controller }
Info [Controller] Excluding HID device { 004c:0265 r0 | Usage: 0001:0002 | Manufacturer: Apple | Product: Magic Trackpad 2 | S/N: XXX }
Info [Controller] Duplicate HID device, excluding { 004c:0265 r0 | Usage: 0001:0001 | Manufacturer: Apple | Product: Magic Trackpad 2 | S/N: XXX }
Info [Controller] Duplicate HID device, excluding { 004c:0265 r0 | Usage: 000d:0005 | Manufacturer: Apple | Product: Magic Trackpad 2 | S/N: XXX }
Info [Controller] Duplicate HID device, excluding { 004c:0265 r0 | Usage: ff00:000c | Manufacturer: Apple | Product: Magic Trackpad 2 | S/N: XXX }
Info [Controller] Found HID device: { 05ac:0278 r896 | Usage: ff00:000d | Interface: #3 | Product: Apple Internal Keyboard / Trackpad }
Info [Controller] Found HID device: { 004c:0265 r107 | Usage: 0000:0001 | Manufacturer: Apple | Product: Magic Trackpad 2 | S/N: XXX }
Info [Controller] Found HID device: { 05ac:0278 r896 | Usage: ff00:000b | Interface: #0 | Product: Apple Internal Keyboard / Trackpad }
Info [Controller] Found HID device: { 004c:0265 r0 | Usage: ff00:000d | Manufacturer: Apple | Product: Magic Trackpad 2 | S/N: XXX }
Info [Controller] Excluding HID device { 05ac:0278 r896 | Usage: 0001:0006 | Product: Apple Internal Keyboard / Trackpad }
Info [Controller] Duplicate HID device, excluding { 05ac:0278 r896 | Usage: 000c:0001 | Product: Apple Internal Keyboard / Trackpad }
Info [Controller] Duplicate HID device, excluding { 05ac:0278 r896 | Usage: ff00:0006 | Product: Apple Internal Keyboard / Trackpad }
Info [Controller] Duplicate HID device, excluding { 05ac:0278 r896 | Usage: ff00:000f | Product: Apple Internal Keyboard / Trackpad }

Be-ing · 2021-09-02T12:58:55Z

Apple is likely to keep changing the product IDs of their laptop components over time. I suggest we disallow any HID device with Apple's vendor ID. Thoughts?

foss- · 2021-09-08T12:21:26Z

2.4-alpha-793-g169cd3e4ac (main) no longer shows Apple Internal Keyboard or Apple T1 Controller. However it still does show the external Magic Trackpad 2. Would that be expected?

Be-ing · 2021-09-08T12:23:13Z

Taking another look at the log you posted above, that device has a different vendor ID...

foss- · 2021-09-08T12:28:13Z

Manufacturer: Apple | Product: Magic Trackpad 2
Manufacturer: Apple Inc. | Product: Apple T1 Controller

Right, so should that also be added to exclusion list?

Be-ing · 2021-09-08T12:38:39Z

I suppose so.

do not allow using keyboards and mice as HID controllers

b4bfe76

Enabling a keyboard or mouse as an HID controller makes it stop working as a keyboard or mouse.

Be-ing force-pushed the hide_keyboards_and_mice branch from 6594bc8 to b4bfe76 Compare August 25, 2021 05:43

daschuer previously requested changes Aug 25, 2021

View reviewed changes

uklotzde added this to the 2.3.1 milestone Aug 25, 2021

uklotzde approved these changes Aug 25, 2021

View reviewed changes

uklotzde added changelog This PR should be included in the changelog major bug labels Aug 25, 2021

uklotzde merged commit 6cd39a5 into mixxxdj:2.3 Sep 1, 2021

Be-ing deleted the hide_keyboards_and_mice branch September 2, 2021 12:58

This was referenced Sep 4, 2021

hid_enumerate with hidraw backend returns lots of duplicate hid_device_infos libusb/hidapi#298

Closed

HidEnumerator: skip all HID devices with Apple's vendor ID #4260

Merged

This was referenced Sep 8, 2021

HidEnumerator: skip HID devices with Apple's other vendor ID #4273

Merged

Vamp SDK filename fixes tenacityteam/tenacity-legacy#584

Merged

mixxxbot mentioned this pull request Aug 23, 2022

mice and keyboards stop working if enabled as HID controllers #10498

Closed

JoergAtGithub mentioned this pull request Jan 27, 2024

Mixxx hang (infinite) at startup, when a secondary monitor is the application window target and RunAs Admin is NOT used #12655

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

do not allow using keyboards and mice as HID controllers #4243

do not allow using keyboards and mice as HID controllers #4243

Be-ing commented Aug 25, 2021

daschuer left a comment

daschuer Aug 25, 2021

Be-ing Aug 25, 2021

daschuer Aug 25, 2021

Be-ing Aug 25, 2021

Be-ing commented Aug 25, 2021 •

edited

Be-ing commented Aug 25, 2021 •

edited

daschuer commented Aug 25, 2021

Be-ing commented Aug 25, 2021

Holzhaus commented Aug 25, 2021

uklotzde left a comment

uklotzde commented Aug 27, 2021

Be-ing commented Aug 31, 2021

uklotzde commented Sep 1, 2021

uklotzde commented Sep 1, 2021

Holzhaus commented Sep 1, 2021

foss- commented Sep 2, 2021 •

edited

uklotzde commented Sep 2, 2021

foss- commented Sep 2, 2021

Be-ing commented Sep 2, 2021

foss- commented Sep 8, 2021

Be-ing commented Sep 8, 2021

foss- commented Sep 8, 2021

Be-ing commented Sep 8, 2021

do not allow using keyboards and mice as HID controllers #4243

do not allow using keyboards and mice as HID controllers #4243

Conversation

Be-ing commented Aug 25, 2021

daschuer left a comment

Choose a reason for hiding this comment

daschuer Aug 25, 2021

Choose a reason for hiding this comment

Be-ing Aug 25, 2021

Choose a reason for hiding this comment

daschuer Aug 25, 2021

Choose a reason for hiding this comment

Be-ing Aug 25, 2021

Choose a reason for hiding this comment

Be-ing commented Aug 25, 2021 • edited

Be-ing commented Aug 25, 2021 • edited

daschuer commented Aug 25, 2021

Be-ing commented Aug 25, 2021

Holzhaus commented Aug 25, 2021

uklotzde left a comment

Choose a reason for hiding this comment

uklotzde commented Aug 27, 2021

Be-ing commented Aug 31, 2021

uklotzde commented Sep 1, 2021

uklotzde commented Sep 1, 2021

Holzhaus commented Sep 1, 2021

foss- commented Sep 2, 2021 • edited

uklotzde commented Sep 2, 2021

foss- commented Sep 2, 2021

Be-ing commented Sep 2, 2021

foss- commented Sep 8, 2021

Be-ing commented Sep 8, 2021

foss- commented Sep 8, 2021

Be-ing commented Sep 8, 2021

Be-ing commented Aug 25, 2021 •

edited

Be-ing commented Aug 25, 2021 •

edited

foss- commented Sep 2, 2021 •

edited