lp1934785 SoundSourceFFmpeg: Ignore inaudible samples before start of stream #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add overridable compile time options for analyzing gaps and overlaps in the decoded audio stream.
…-soundsourceffmpeg
Verify that successfully decoded frames contain valid audio data before continuing.
|
Ping. This is an easy, straightforward bug fix, only the analysis was tricky. |
Holzhaus
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of FFmpeg is lacking. This is defined nowhere and I also didn't find any examples that handle this case.
Reporting of inaudible samples might have been introduced by FFmpeg 4.4, either deliberately or accidentally. That's probably the reason why we didn't notice any issues with earlier versions.
Fixes https://bugs.launchpad.net/mixxx/+bug/1934785