SoundSourceOpus: Fix invocation of inherited method #4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
approved these changes
Aug 29, 2021
|
Thank you. |
|
As this apparently fixes a crash, we should add it to the changelog. |
|
This fix was pure speculation. We don't know if 2.3.1 would be affected nor if this fixes the issue if it actually occurs. 2.3.0 is not affected as the bug reports states. |
|
OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A finding while analyzing https://bugs.launchpad.net/mixxx/+bug/1940777. Not sure if this inaccuracy could cause a crash on Windows depending on the compiler version and settings.
The member function is defined in
MetadataSourceTagLib, a base class ofSoundSource.For main this fix will soon become obsolete after #4251 has been merged.