Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeatFactory: Round beatgrid frame positions in makePreferredBeats() #4263

Merged
merged 1 commit into from
Sep 4, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Sep 4, 2021

Due to our internal beatgrid storage format, fractional beat positions
are not allowed.

Fixes https://github.com/mixxxdj/mixxx/pull/4258/files#r702285221.

Alternative to #4261.

Due to our internal beatgrid storage format, fractional beat positions
are not allowed.

Fixes https://github.com/mixxxdj/mixxx/pull/4258/files#r702285221.

Alternative to mixxxdj#4261.
@Holzhaus Holzhaus added this to the 2.4.0 milestone Sep 4, 2021
@Holzhaus Holzhaus added this to In progress in Beats Refactoring via automation Sep 4, 2021
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit d585e26 into mixxxdj:main Sep 4, 2021
Beats Refactoring automation moved this from In progress to Done Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants