Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beats: Hide beatmap/beatgrid implementation from calling code #4268

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Sep 7, 2021

Another step towards merging the two beats implementations into a single one.

@Holzhaus Holzhaus added the engine label Sep 7, 2021
@Holzhaus Holzhaus added this to In progress in Beats Refactoring via automation Sep 7, 2021
@Holzhaus Holzhaus force-pushed the beats-private branch 2 times, most recently from ff66b71 to 3cc55e3 Compare September 7, 2021 11:34
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With all the type-safety in place this refactoring is easy to review :) LGTM

Unrelated comment: For the future I would like to use the term "steady tempo" instead of "const tempo". Maybe some native speaker could comment or we could also discuss it on Zulip.

@uklotzde uklotzde merged commit 4989a4b into mixxxdj:main Sep 9, 2021
Beats Refactoring automation moved this from In progress to Done Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants