Add more eslint rules #4278
Merged
Add more eslint rules #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but i think this PR should be split up. Some new rules should already go into 2.3. |
|
Which rules in particular or just all of them? |
|
Let and const don't work in 2.3. And I think bind does neither. So all rules that relate to that (e. g. |
Swiftb0y
force-pushed
the
eslint-rules
branch
from
adbe45c
to
b2e1d21
Compare
|
merge? This way I can merge 2.3 into main and issue the follow-up PR to main. |
Holzhaus
approved these changes
Sep 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I frequently find myself manually correcting many of these during code review so I figured I'd add them to the eslint rules to be enforced automatically. I'm open to removing some rules if others disagree with my style-choices. I also did not think much about severity yet, so I just categorized everything as "warn" for now, but thats also up for discussion.
I also removed the deprecated
print()global while I was at it.