I have a Numark MixTrack Pro II

.clang-format

@@ -31,15 +31,14 @@ SpacesBeforeTrailingComments: 1
 # StatementMacros don't require a trailing semicolon.
 # Trailing semicolons should be omitted after these macros
 # when compiling with -Wpedantic to avoid warnings.
-# TODO: Enable if Clang 8 is available, Ubuntu 18.04 uses Clang 6
-#StatementMacros:
-#  - Q_DECLARE_FLAGS
-#  - Q_DECLARE_METATYPE
-#  - Q_DECLARE_OPERATORS_FOR_FLAGS
-#  - Q_OBJECT
-#  - Q_PROPERTY
-#  - Q_UNUSED
-#  - QT_REQUIRE_VERSION
+StatementMacros:
+  - Q_DECLARE_FLAGS
+  - Q_DECLARE_METATYPE
+  - Q_DECLARE_OPERATORS_FOR_FLAGS
+  - Q_OBJECT
+  - Q_PROPERTY
+  - Q_UNUSED
+  - QT_REQUIRE_VERSION
 ---
 Language: JavaScript
 # Don't format .js files yet

.codespellignore

@@ -2,3 +2,4 @@ Crate
 crate
 InOut
 copyable
+sord

.eslintrc.json

@@ -1,9 +1,12 @@
 {
   "extends": "eslint:recommended",
   "parserOptions": {
-    "ecmaVersion": 5,
+    "ecmaVersion": 7,
     "sourceType": "script"
   },
+  "env": {
+    "es6": true
+  },
   "rules": {
     "array-bracket-spacing" : "warn",
     "block-spacing": "warn",
@@ -39,11 +42,13 @@
     "no-unused-vars": ["error", {
         "argsIgnorePattern": "^_"
     }],
+    "no-var": "warn",
     "object-curly-newline" : ["warn", {
         "consistent": true,
         "multiline": true
     }],
     "object-curly-spacing" : "warn",
+    "prefer-const": "warn",
     "prefer-regex-literals": "warn",
     "quotes": ["warn", "double"],
     "require-atomic-updates": "error",
@@ -57,7 +62,6 @@
   "globals": {
     "console": "writable",
     "svg": "writable",
-    "print": "readonly",
     "HIDController": "writable",
     "HIDDebug": "writable",
     "HIDPacket": "writable",

.github/FUNDING.yml

@@ -1 +1 @@
-custom: "https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=QSFMYWN2B3JD2&source=url"
+custom: "https://mixxx.org/donate"

.github/workflows/build-checks.yml

@@ -11,49 +11,14 @@ jobs:
         include:
           - name: clazy
           - name: clang-tidy
+          - name: coverage
     runs-on: ubuntu-20.04
     name: ${{ matrix.name }}
     steps:
     - name: Check out repository
       uses: actions/checkout@v2
     - name: Install build dependencies
-      run: |
-        sudo apt-get update && sudo apt-get install -y --no-install-recommends \
-          libavformat-dev \
-          libchromaprint-dev \
-          libebur128-dev \
-          libfftw3-dev \
-          libflac-dev \
-          libid3tag0-dev \
-          liblilv-dev \
-          libmad0-dev \
-          libmodplug-dev \
-          libmp3lame-dev \
-          libopus-dev \
-          libopusfile-dev \
-          libportmidi-dev \
-          libprotobuf-dev \
-          libqt5opengl5-dev \
-          libqt5sql5-sqlite \
-          libqt5svg5-dev \
-          libqt5x11extras5-dev \
-          librubberband-dev \
-          libshout-idjc-dev \
-          libsndfile1-dev \
-          libsoundtouch-dev \
-          libsqlite3-dev \
-          libtag1-dev \
-          libupower-glib-dev \
-          libusb-1.0-0-dev \
-          libwavpack-dev \
-          portaudio19-dev \
-          protobuf-compiler \
-          qt5-default \
-          qtscript5-dev \
-          qt5keychain-dev \
-          clazy \
-          clang-tidy \
-          cmake
+      run: tools/debian_buildenv.sh setup
     - name: Create build directory
       run: mkdir build
     - name: Configure (clazy)
@@ -107,6 +72,31 @@ jobs:
           -DWAVPACK=ON \
           ..
       working-directory: build
+    - name: Configure (coverage)
+      if: matrix.name == 'coverage'
+      run: |
+        cmake \
+          -DCMAKE_BUILD_TYPE=Debug \
+          -DOPTIMIZE=off \
+          -DCOVERAGE=ON \
+          -DWARNINGS_FATAL=OFF \
+          -DDEBUG_ASSERTIONS_FATAL=OFF \
+          -DBATTERY=ON \
+          -DBROADCAST=ON \
+          -DBULK=ON \
+          -DHID=ON \
+          -DLILV=ON \
+          -DOPUS=ON \
+          -DQTKEYCHAIN=ON \
+          -DVINYLCONTROL=ON \
+          -DFFMPEG=ON \
+          -DKEYFINDER=ON \
+          -DLOCALECOMPARE=ON \
+          -DMAD=ON \
+          -DMODPLUG=ON \
+          -DWAVPACK=ON \
+          ..
+      working-directory: build
     - name: Set up problem matcher
       uses: ammaraskar/gcc-problem-matcher@master
     - name: Build
@@ -116,3 +106,35 @@ jobs:
       env:
         CLAZY_CHECKS: level2,no-rule-of-two-soft,no-non-pod-global-static,no-qproperty-without-notify,no-wrong-qevent-cast,no-qstring-allocations,no-function-args-by-value,no-copyable-polymorphic,no-ctor-missing-parent-argument,no-missing-qobject-macro,no-rule-of-three,no-returning-void-expression,no-missing-typeinfo,no-base-class-event
         CLAZY_IGNORE_DIRS: lib/.*
+    - name: "Test"
+      if: matrix.name == 'coverage'
+      run: ctest --timeout 45
+      working-directory: build
+      env:
+        # Render analyzer waveform tests to an offscreen buffer
+        QT_QPA_PLATFORM: ${{ matrix.qt_qpa_platform }}
+        GTEST_COLOR: 1
+        # Only use single thread to prevent *.gcna files from overwriting each other
+        CTEST_PARALLEL_LEVEL: 1
+        CTEST_OUTPUT_ON_FAILURE: 1
+    - name: "Generate Coverage Report"
+      if: matrix.name == 'coverage'
+      run: >-
+        lcov
+        --capture
+        --directory .
+        --base-directory ..
+        --include "${PWD%/*}/src/*"
+        --exclude "${PWD%/*}/src/test/*"
+        --exclude "${PWD%/*}/build/*"
+        --exclude "${PWD%/*}/lib/*"
+        --output-file lcov.info
+      working-directory: build
+    - name: "Upload Coverage Report to coveralls.io"
+      if: matrix.name == 'coverage'
+      continue-on-error: true
+      uses: coverallsapp/github-action@master
+      with:
+        flag-name: ubuntu-20.04
+        path-to-lcov: build/lcov.info
+        github-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/build.yml

@@ -10,28 +10,6 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - name: Ubuntu 18.04 (gcc)
-            os: ubuntu-18.04
-            cmake_args: >-
-              -DWARNINGS_FATAL=ON
-              -DBULK=ON
-              -DFAAD=ON
-              -DFFMPEG=OFF
-              -DLOCALECOMPARE=ON
-              -DMAD=ON
-              -DMODPLUG=ON
-              -DWAVPACK=ON
-              -DINSTALL_USER_UDEV_RULES=OFF
-            ctest_args:
-            compiler_cache: ccache
-            compiler_cache_path: ~/.ccache
-            cpack_generator: DEB
-            buildenv_basepath: /home/runner/buildenv
-            buildenv_script: tools/debian_buildenv.sh
-            artifacts_name: Ubuntu 18.04 DEB
-            artifacts_path: build/*.deb
-            artifacts_slug: ubuntu-bionic
-            qt_qpa_platform: offscreen
           - name: Ubuntu 20.04 (gcc)
             os: ubuntu-20.04
             cmake_args: >-
@@ -75,7 +53,7 @@ jobs:
             qt_qpa_platform: offscreen
           - name: Windows 2019 (MSVC)
             os: windows-2019
-            # TODO: Reenable FFmpeg after licensing issues have been clarified
+            # TODO: Re-enable FFmpeg after licensing issues have been clarified
             # Attention: If you change the cmake_args for the Windows CI build,
             #            also adjust the for the local Windows build setup in
             #            ./tools/windows_buildenv.bat
@@ -147,20 +125,25 @@ jobs:
       # Possibly related: actions/checkout#290
       run: git fetch origin --force --tags
 
-    - name: "[macOS/Ubuntu 18.04] Set up cmake"
-      uses: jwlawson/actions-setup-cmake@v1.4
+    - name: "[macOS] Set up cmake"
+      uses: jwlawson/actions-setup-cmake@v1.9
       # Ubuntu 20.04 should use the CMake version from the repos, and Visual
       # Studio on Windows comes with its own CMake version anyway.
-      if: runner.os == 'macOS' || matrix.os == 'ubuntu-18.04'
+      if: runner.os == 'macOS'
       with:
-        # This should always match the mininum required version in
+        # This should always match the minimum required version in
         # our CMakeLists.txt
         cmake-version: '3.16.x'
 
     - name: "[Windows] Set up MSVC Developer Command Prompt"
       if: runner.os == 'Windows'
       uses: seanmiddleditch/gha-setup-vsdevenv@v3
 
+    - name: "[macOS] install ccache and make"
+      if: runner.os == 'macOS'
+      run: |
+        brew install ccache ninja
+
     - name: "[macOS/Windows] Get build environment name"
       if: runner.os != 'Linux'
       id: buildenv_name
@@ -309,8 +292,8 @@ jobs:
       # No need to do the PPA build for both Ubuntu versions
       if: matrix.os == 'ubuntu-20.04'
       run: |
-        if [[ "${{ github.ref }}" == "refs/heads/2.3" ]] && [[ "${{ github.repository }}" == "mixxxdj/mixxx" ]]; then
-          CPACK_ARGS="-D DEB_UPLOAD_PPA=ppa:mixxx/mixxxbetas"
+        if [[ "${{ github.ref }}" == "refs/heads/main" ]] && [[ "${{ github.repository }}" == "mixxxdj/mixxx" ]]; then
+          CPACK_ARGS="-D DEB_UPLOAD_PPA=ppa:mixxx/nightlies -D CPACK_DEBIAN_DEBIAN_VERSION=0ubuntu2"
         elif [[ "${{ github.ref }}" =~ ^refs/tags/[0-9]+\.[0-9]+\.[0-9]+$ ]] && [[ "${{ github.repository }}" == "mixxxdj/mixxx" ]]; then
           CPACK_ARGS="-D DEB_UPLOAD_PPA=ppa:mixxx/mixxx"
         else

.github/workflows/pre-commit.yml

@@ -8,26 +8,23 @@ jobs:
   pre-commit:
     name: Detecting code style issues
     runs-on: ubuntu-latest
+    # The Dockerfile for this container can be found at:
+    # https://github.com/Holzhaus/mixxx-ci-docker
+    container: holzhaus/mixxx-ci:20210923
     steps:
     - name: "Check out repository"
       uses: actions/checkout@v2
       with:
         fetch-depth: 2
 
-    - name: "Set up Python"
-      uses: actions/setup-python@v2
-
-    - name: Install clang-format
-      run: sudo apt-get update && sudo apt-get install -y --no-install-recommends clang-format-10
-
     - name: "Detect code style issues (push)"
       uses: pre-commit/action@v2.0.3
       if: github.event_name == 'push'
       # There are too many files in the repo that have formatting issues. We'll
       # disable these checks for now when pushing directly (but still run these
       # on Pull Requests!).
       env:
-        SKIP: end-of-file-fixer,trailing-whitespace,clang-format,eslint,no-commit-to-branch
+        SKIP: clang-format,eslint,no-commit-to-branch
 
     - name: "Detect code style issues (pull_request)"
       uses: pre-commit/action@v2.0.3
@@ -54,9 +51,6 @@ jobs:
         name: ${{ env.UPLOAD_PATCH_FILE }}
         path: ${{ env.UPLOAD_PATCH_FILE }}
 
-    - name: "Install appstreamcli"
-      run: sudo apt-get update && sudo apt-get install -y --no-install-recommends appstream
-
     # AppStream metadata has been generated/updated by a pre-commit hook
     - name: "Validate AppStream metadata"
       run: appstreamcli validate res/linux/org.mixxx.Mixxx.metainfo.xml