Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use vcpkg dependencies with SoundTouch 2.3.1 & libdjinterop 0.16.0 #4338

Merged
merged 1 commit into from
Sep 30, 2021
Merged

use vcpkg dependencies with SoundTouch 2.3.1 & libdjinterop 0.16.0 #4338

merged 1 commit into from
Sep 30, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Sep 29, 2021

This will allow devendoring SoundTouch and no longer relying on the automatic downloading of libdjinterop by CMake.

@Be-ing
Copy link
Contributor Author

Be-ing commented Sep 29, 2021

CMake is still failing to find SoundTouch and libdjinterop...

@Be-ing Be-ing force-pushed the vcpkg_soundtouch_libdjinterop branch from a35a6dd to 2a4637e Compare September 29, 2021 23:53
@Be-ing
Copy link
Contributor Author

Be-ing commented Sep 30, 2021

CMake is finding SoundTouch and libdjinterop on macOS and Windows builds now. Merge?

daschuer
daschuer approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit bea70ca into mixxxdj:main Sep 30, 2021
@Be-ing Be-ing deleted the vcpkg_soundtouch_libdjinterop branch September 30, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Be-ing @daschuer