Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard: Enter in library is double-click, change Preview shortcuts #4359

Closed
wants to merge 5 commits into from

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 6, 2021

as proposed in https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/keyboard.20shortcuts

1 pressing Enter in the tracks table triggers the configured double-click action.
(currently used to stop the preview deck)

2 move & extend preview deck shortcuts
Screenshot_2021-10-06_13-41-58

Optional
use - and = for Load to deck 1/2 (could be helpful if the selected track changed) Edit Only cloning is possible, no simple "load", and I'm not sure that is desired. Dismissed.
' and \ for seeking

ToDo

  • change all remaining~.kbd.cfg
  • update mapping sheet PNG for the manual

@github-actions github-actions bot added the ui label Oct 6, 2021
@ronso0 ronso0 added the library label Oct 6, 2021
@ronso0 ronso0 added this to In progress in 2.4 release via automation Oct 6, 2021
@ronso0 ronso0 added the changelog This PR should be included in the changelog label Oct 6, 2021
@ronso0 ronso0 marked this pull request as draft October 6, 2021 12:19
@ronso0 ronso0 force-pushed the keyboard-sheet-cleanup-preview branch from 00442b8 to 44e93d0 Compare October 6, 2021 12:21
@ronso0
Copy link
Member Author

ronso0 commented Oct 6, 2021

can be tested with de_DE and en_US

@ronso0 ronso0 force-pushed the keyboard-sheet-cleanup-preview branch from 44e93d0 to 5d3bc7a Compare October 7, 2021 00:45
@ronso0 ronso0 moved this from In progress to Needs review in 2.4 release Oct 7, 2021
@ronso0 ronso0 added this to the 2.4.0 milestone Oct 7, 2021
@ronso0
Copy link
Member Author

ronso0 commented Oct 16, 2021

If there are no objections I'll adapt the remaining keyboard mappings.

@ronso0 ronso0 force-pushed the keyboard-sheet-cleanup-preview branch from 5d3bc7a to d41becd Compare October 16, 2021 19:42
@ronso0
Copy link
Member Author

ronso0 commented Oct 19, 2021

If there are no objections I'll adapt the remaining keyboard mappings.

ping

@daschuer
Copy link
Member

I have no objections.

@ronso0 ronso0 force-pushed the keyboard-sheet-cleanup-preview branch from d41becd to 511408f Compare October 21, 2021 21:38
@ronso0
Copy link
Member Author

ronso0 commented Dec 18, 2021

Ufff, seems I need to swap the play/pause key because in some keyboard layouts it's either a modifier (no own output) or some special key that needs to be pressed twice to send the required key code. I tried with ^ with the german keyboard and the keypress is not printed by the keyboard event filter :\

I'll czech if there's a usable common key n all included layouts ; |

@ronso0 ronso0 moved this from Needs review to In progress in 2.4 release Mar 16, 2022
@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Mar 19, 2022
@daschuer daschuer removed this from the 2.4.0 milestone Jul 5, 2022
@github-actions github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Sep 8, 2023
@ronso0 ronso0 closed this Jan 23, 2024
2.4 release automation moved this from In progress to Done Jan 23, 2024
@ronso0 ronso0 deleted the keyboard-sheet-cleanup-preview branch January 23, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This PR should be included in the changelog library ui
Projects
2.4 release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants