Fix eq apply-to-all in preferences. #437
Conversation
* slotLoadEffectChainInSlot was deleted, so the emit did nothing. Create a function to fix that behavior. * Don't instant-apply eq and quickeffect selections -- wait for the user to hit apply. (Otherwise, what's the point of an apply button?) fixes lp:1404525
| @@ -331,6 +331,34 @@ EqualizerRack::EqualizerRack(EffectsManager* pEffectsManager, | |||
| EqualizerRack::formatGroupString(iRackNumber)) { | |||
| } | |||
|
|
|||
| bool EqualizerRack::loadEffectToGroup(const QString& group, | |||
There was a problem hiding this comment.
this is copied from the QuickEffectRack -- it might make sense to make this a generic function that all racks have.
There was a problem hiding this comment.
It was at one point and I removed it :) it doesn't make sense for non PerGroupRacks. I think they were slightly different but if they are actually the same now then it could be added to PerGroupRack.
There was a problem hiding this comment.
we can leave it as dupe code for now
|
Just tested it and there is still an issue with the "Use the same .." check box. |
|
that's actually on purpose. It remembers what the individual choices were in case you want to go back and forth. But when the settings are applied to all, they are |
|
That is confusing for me. Why is Deck 1 changed, but the others not? What is special to Deck 1? Does the "Use the same .." checkbox ignore the individual settings from cfg file? I would prefer a consistent dependency; checkbox checked, all cfg values equal. |
|
ok fixed |
| EffectSlotPointer pEffectSlot = pChainSlot->getEffectSlot(0); | ||
| if (pEffectSlot) { | ||
| pEffectSlot->onChainSuperParameterChanged( | ||
| pChainSlot->getSuperParameter(), true); |
There was a problem hiding this comment.
That must not be done for EQs since we have no superknob on the EQ Racks.
This will override the Effect defaults of the effects with a superknob binding.
The force parameter is a quick effect only thing.
|
LGTM, Thank you! |
Fix eq apply-to-all in preferences.
a function to fix that behavior.
(Otherwise, what's the point of an apply button?)
fixes lp:1404525