Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DAZ flag for SSE builds, to avoid a penalty by denormals calculation... #438

Merged
merged 4 commits into from Feb 2, 2015

Conversation

daschuer
Copy link
Member

..., Bug #1404401

@@ -697,14 +690,6 @@ int SoundDevicePortAudio::callbackProcess(const unsigned int framesPerBuffer,
Q_UNUSED(timeInfo);
Trace trace("SoundDevicePortAudio::callbackProcess " + getInternalName());

//qDebug() << "SoundDevicePortAudio::callbackProcess:" << getInternalName();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because m_bSetThreadPriority is only a guard for the clock reference device.
In current master it may happens that the engine thread is not at real time priority, because the headphone soundcard gets the priority first.

If it turn out that we need real time processing for the second soundcard as well, this should be handled in a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daschuer
Copy link
Member Author

It this mergeable now?

@daschuer
Copy link
Member Author

daschuer commented Feb 2, 2015

Just get an underflow due to denormals, when pausing deck A.
I will merge that now to get rid of it.

daschuer added a commit that referenced this pull request Feb 2, 2015
Set DAZ flag for SSE builds, to avoid a penalty by denormals calculation...
@daschuer daschuer merged commit 3907041 into mixxxdj:master Feb 2, 2015
@daschuer daschuer deleted the daz branch May 30, 2015 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants