ConfigObject: guard QTextStream::setCodec behind Qt version check #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
suggested changes
Oct 13, 2021
Be-ing
force-pushed
the
configobject_setcodec
branch
from
f82eb1c
to
5102c9b
Compare
uklotzde
suggested changes
Oct 13, 2021
Be-ing
force-pushed
the
configobject_setcodec
branch
from
5102c9b
to
7e50c41
Compare
uklotzde
reviewed
Oct 13, 2021
uklotzde
reviewed
Oct 13, 2021
QTextSTream::setCodec was removed in Qt6: https://bugreports.qt.io/browse/QTBUG-75665
Be-ing
force-pushed
the
configobject_setcodec
branch
from
7e50c41
to
efa0417
Compare
|
CI passed. Merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QTextSTream::setCodec was removed in Qt6:
https://bugreports.qt.io/browse/QTBUG-75665