Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DbId: fix build with Qt6 #4417

Merged
merged 1 commit into from
Oct 14, 2021
Merged

DbId: fix build with Qt6 #4417

merged 1 commit into from
Oct 14, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 14, 2021

No description provided.

@Be-ing Be-ing added this to In progress in Qt6 via automation Oct 14, 2021
uklotzde
uklotzde approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready after adjusting the (undetected) indentation issues.

PS: I already fixed that recently in my attempt to improve DbId. Killed by bike shedding discussions.

uklotzde
uklotzde suggested changes Oct 14, 2021
View reviewed changes
src/util/db/dbid.h Show resolved Hide resolved
uklotzde
uklotzde approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit c21f8b5 into mixxxdj:main Oct 14, 2021
Qt6 automation moved this from In progress to Done Oct 14, 2021
@Be-ing Be-ing deleted the dbid_qmetatype branch October 14, 2021 21:11
@daschuer daschuer mentioned this pull request Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer left review comments

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Qt6
Status: Done
Qt6
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Be-ing @uklotzde @daschuer