Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseTrackTableModel: fix Qt6 QVariant deprecation warning #4446

Merged
merged 1 commit into from Oct 17, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 16, 2021

../src/library/basetracktablemodel.cpp: In member function ‘QVariant BaseTrackTableModel::roleValue(const QModelIndex&, QVariant&&, int) const’:
../src/library/basetracktablemodel.cpp:649:30: warning: ‘QVariant::Type QVariant::type() const’ is deprecated: Use typeId() or metaType(). [-Wdeprecated-declarations]
  649 |             if (rawValue.type() == QVariant::String) {
      |                 ~~~~~~~~~~~~~^~
In file included from /usr/include/qt6/QtCore/qabstractitemmodel.h:47,
                 from /usr/include/qt6/QtCore/QAbstractTableModel:1,
                 from ../src/library/basetracktablemodel.h:3,
                 from ../src/library/basetracktablemodel.cpp:1:
/usr/include/qt6/QtCore/qvariant.h:337:10: note: declared here
  337 |     Type type() const
      |          ^~~~

@Be-ing Be-ing added this to In progress in Qt6 via automation Oct 16, 2021
../src/library/basetracktablemodel.cpp: In member function ‘QVariant BaseTrackTableModel::roleValue(const QModelIndex&, QVariant&&, int) const’:
../src/library/basetracktablemodel.cpp:649:30: warning: ‘QVariant::Type QVariant::type() const’ is deprecated: Use typeId() or metaType(). [-Wdeprecated-declarations]
  649 |             if (rawValue.type() == QVariant::String) {
      |                 ~~~~~~~~~~~~~^~
In file included from /usr/include/qt6/QtCore/qabstractitemmodel.h:47,
                 from /usr/include/qt6/QtCore/QAbstractTableModel:1,
                 from ../src/library/basetracktablemodel.h:3,
                 from ../src/library/basetracktablemodel.cpp:1:
/usr/include/qt6/QtCore/qvariant.h:337:10: note: declared here
  337 |     Type type() const
      |          ^~~~
@Be-ing Be-ing force-pushed the basetracktablemodel_qmetatype branch from 4918c86 to 38a5f02 Compare October 16, 2021 23:14
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Holzhaus Holzhaus merged commit 02a3769 into mixxxdj:main Oct 17, 2021
Qt6 automation moved this from In progress to Done Oct 17, 2021
@Be-ing Be-ing deleted the basetracktablemodel_qmetatype branch October 17, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Qt6
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants