TrackModel::getTrackUrl() #4477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think there's a harm in doing this but the legacy LibraryFeatures won't be used with Qt6 so I'm not sure what the benefit is? |
Be-ing
reviewed
Oct 23, 2021
| @@ -115,14 +125,12 @@ class TrackModel { | |||
| // empty list if the track ID is not present in the result set. | |||
| virtual const QVector<int> getTrackRows(TrackId trackId) const = 0; | |||
|
|
|||
| bool isTrackModel() { return true;} | |||
There was a problem hiding this comment.
phew that's some dusty old code... last touched in 2009
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more tiny step to decouple the internal database from the UI.