TrackAnalysisScheduler: Remove dependency on TrackDAO #4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
approved these changes
Oct 24, 2021
Swiftb0y
reviewed
Oct 24, 2021
| } | ||
| ~TrackAnalysisSchedulerEnvironmentImpl() override = default; | ||
|
|
||
| TrackPointer loadTrackById(TrackId trackId) const override { |
There was a problem hiding this comment.
marking this final might allow the compiler to optimize the virtual function call away. AFAIK
There was a problem hiding this comment.
not sure if that would make a difference, but it could be done in another PR
There was a problem hiding this comment.
Sure, didn't think about it. This class is indeed supposed to be final.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency injection, basic software engineering.
The term "Environment" for explicitly isolating side-effects in the outer context has been proven useful in other circumstances and projects.