Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controllers: Use console.log instead of engine.log #4524

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

Holzhaus
Copy link
Member

Let's merge this uncontroversial change first. Reduces the PR size of #4523 and hopefully it will make the CI checks green, too.

Holzhaus and others added 2 commits November 16, 2021 21:20
This was the only script directly using engine.log instead of
the print wrapper in common-controller-scripts.js.
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Merge?

@ywwg
Copy link
Member

ywwg commented Nov 16, 2021

style issues are existing old js problems, fine to ignore

Copy link
Member

@ywwg ywwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Swiftb0y ok to merge

@Swiftb0y Swiftb0y merged commit 259b635 into mixxxdj:main Nov 16, 2021
@JoergAtGithub
Copy link
Member

For me console.log doesn't work. If I change common-controller-scripts.js back to engine.log the output from the script appears again.

@Swiftb0y
Copy link
Member

Swiftb0y commented Jan 8, 2022

Did you make sure to use --controllerDebug?

@JoergAtGithub
Copy link
Member

Yes --controllerDebug was defined, I built latest Main from scratch, to ensure that it was not related to my code.
All messages of the C++ part of the controller system appeared. But the messages from JavaScript, where I use HIDDebug were missing in the output. I changed common-controller-scripts.js while Mixxx was loaded, and the HIDDebug messages appeared after the automatic reload of the mapping.

@Swiftb0y
Copy link
Member

Swiftb0y commented Jan 8, 2022

Did you try manually defining the logging category filter?
try this environment variable: QT_LOGGING_RULES="controller.*.debug=true;*.input.debug=false"

@JoergAtGithub
Copy link
Member

No, but Jan fixed this already: #4612

@Holzhaus
Copy link
Member Author

Holzhaus commented Jan 8, 2022

Did you try manually defining the logging category filter?
try this environment variable: QT_LOGGING_RULES="controller.*.debug=true;*.input.debug=false"

The issue is that console.log uses the js logging category instead of controller.*, and --controller-debug doesn't show that category yet.

See #4612.

So QT_LOGGING_RULES="controller.*.debug=true;*.input.debug=false;js.debug=true" would work, too.

@Swiftb0y
Copy link
Member

Swiftb0y commented Jan 8, 2022

Thank you. I just saw the PRs in the wrong order and didn't realize my comment was obsolete before I made it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants