Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fixes when compiling with qt6 #4549

Merged
merged 2 commits into from
Dec 6, 2021
Merged

minor fixes when compiling with qt6 #4549

merged 2 commits into from
Dec 6, 2021

Conversation

vigsterkr
Copy link
Contributor

when compiling on macos monterey CMAKE_OSX_DEPLOYMENT_TARGET requires 10.15 otherwise c++17 filesystem feature is not available.

@github-actions github-actions bot added the build label Dec 2, 2021
Holzhaus
Holzhaus requested changes Dec 2, 2021
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left some comments.

src/util/db/sqlstringformatter.cpp Outdated Show resolved Hide resolved
src/util/cmdlineargs.cpp Outdated Show resolved Hide resolved
@vigsterkr @Holzhaus
Update src/util/db/sqlstringformatter.cpp
bd9645c 
Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>
uklotzde
uklotzde approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributor agreement has already been signed. LGTM

@uklotzde uklotzde merged commit 7531b1f into mixxxdj:main Dec 6, 2021
@daschuer daschuer mentioned this pull request Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywwg ywwg ywwg left review comments

@Holzhaus Holzhaus Holzhaus approved these changes

@Swiftb0y Swiftb0y Swiftb0y left review comments

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vigsterkr @ywwg @uklotzde @Holzhaus @Swiftb0y