lp1980091 TaskMonitor: Reset progress dialog to close it #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issues anymore. The pProgressDlg changes LGTM, though I don't know anything about the thread affinity DEBUG_ASSERTs above. |
daschuer
reviewed
Jun 29, 2022
There was a problem hiding this comment.
LGTM thank you.
The assertion in the beginning of the function will detect, if the function is called from a wrong thread, that might cause an invalid state that prevents closing.
It looks like a debugging leftover to check a first assumption, But it does not hurt to keep that for future regression.
daschuer
approved these changes
Jun 29, 2022
This was referenced Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1980091