New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard shortcut to maximize library view #519
Conversation
…track library to take up all the available screen space.
…Master],maximize_library. Makes the track library to take up all the available screen space.
…ter],maximize_library. Makes the track library to take up all the available screen space.
make sure to test all skins on a fresh (empty) config -- I had to make it unshow_big because it was defaulting to big, which would be very confusing for new users |
@@ -6,7 +6,7 @@ | |||
<Children> | |||
<WidgetStack currentpage="[Library],show_big_current" persist="true"> | |||
<Children> | |||
<WidgetGroup trigger="[Library],unshow_big"> | |||
<WidgetGroup trigger="[Master],maximize_library"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will probably have to invert all of these with a connection modifier thing because unshow_big means "don't show the maximized library"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I`ll take a look.
Seems to work ok for now, but will test a bit more.
There is a logic error with the skin (in master), where you can end up with no widgets at all. Toggle the Library
button and then Big Library
. Not yet sure how to solve that.
Shade: After returning from the big library samplers and effects are shown, even though the controls are disabled Possible extensions: |
… stuck without controls on restart.
… effects and sampler widget
Shade and Deere skins works like a charm now. Thank you. For me it is mege-able in this state. LGTM In LateNight the behavior with the library button, is technically correct, but the user experience is not best when you hit space and the library is disabled. |
Good point. ...
[Library]
show_big_current 0
[Library]
show_current 0
... |
is it in big mode, or is it just turned off? |
please update to a newer version, the Vinyl button hasn't been down there for a while. |
hm, ok. latenight specifies a default of true for show_library, but maybe something else is turning it off? if you switch the default skin to Deere does the library work? |
That works as expected. |
oh, hah, #387 |
This is great :D |
Merged manually (it had conflicts). |
Fixes https://bugs.launchpad.net/mixxx/+bug/1430847
Possible extensions:
persist="true"
so you cant get stuck with just a library on rebootView
menu in the menu barThanks for reviewing.