Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut to maximize library view #519

Merged
merged 11 commits into from Apr 22, 2015

Conversation

esbrandt
Copy link
Contributor

Fixes https://bugs.launchpad.net/mixxx/+bug/1430847

Possible extensions:

  • Remove persist="true" so you cant get stuck with just a library on reboot
  • Add to the View menu in the menu bar
  • Add to the Midi Wizard

Thanks for reviewing.

@esbrandt esbrandt added this to the 1.12 milestone Mar 11, 2015
@esbrandt esbrandt self-assigned this Mar 11, 2015
@ywwg
Copy link
Member

ywwg commented Mar 11, 2015

make sure to test all skins on a fresh (empty) config -- I had to make it unshow_big because it was defaulting to big, which would be very confusing for new users

@@ -6,7 +6,7 @@
<Children>
<WidgetStack currentpage="[Library],show_big_current" persist="true">
<Children>
<WidgetGroup trigger="[Library],unshow_big">
<WidgetGroup trigger="[Master],maximize_library">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will probably have to invert all of these with a connection modifier thing because unshow_big means "don't show the maximized library"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I`ll take a look.
Seems to work ok for now, but will test a bit more.

There is a logic error with the skin (in master), where you can end up with no widgets at all. Toggle the Library button and then Big Library. Not yet sure how to solve that.

@daschuer
Copy link
Member

Shade: After returning from the big library samplers and effects are shown, even though the controls are disabled

Possible extensions:
sounds all reasonable

@daschuer
Copy link
Member

Shade and Deere skins works like a charm now. Thank you. For me it is mege-able in this state. LGTM

In LateNight the behavior with the library button, is technically correct, but the user experience is not best when you hit space and the library is disabled.
@ywwg: Do we still need the library button or it is possible to replace it with an Auto Hide feature when there is no reasonable space for the small library. For me there is no use case for a entirely blank skin after hitting space.

@esbrandt
Copy link
Contributor Author

make sure to test all skins on a fresh (empty) config -- I had to make it unshow_big because it was defaulting to big, which would be very confusing for new users

Good point.
I think there is a bug with LateNight in master that needs to be fixed first. When launching Mixxx for the 1st time, we default to LateNight without displaying a library at all. The following keys are in the fresh *.cfg:

...

[Library]
show_big_current 0

[Library]
show_current 0

...

@ywwg
Copy link
Member

ywwg commented Mar 23, 2015

without displaying a library at all

is it in big mode, or is it just turned off?

@esbrandt
Copy link
Contributor Author

Like so
mixxx-1

@ywwg
Copy link
Member

ywwg commented Mar 23, 2015

please update to a newer version, the Vinyl button hasn't been down there for a while.

@esbrandt
Copy link
Contributor Author

please update to a newer version

Indeed, for whatever reason i was at r5042.
Updated to latest r5297, and the issue persists. Virgin install = No library with LateNight.
about mixxx

@ywwg
Copy link
Member

ywwg commented Mar 23, 2015

hm, ok. latenight specifies a default of true for show_library, but maybe something else is turning it off? if you switch the default skin to Deere does the library work?

@esbrandt
Copy link
Contributor Author

if you switch the default skin to Deere does the library work

That works as expected.
During 1st run when switching from LateNight with no library to Deere, the library is displayed there.

@ywwg
Copy link
Member

ywwg commented Mar 23, 2015

oh, hah, #387

@rryan
Copy link
Member

rryan commented Apr 22, 2015

This is great :D

@rryan rryan merged commit fc94562 into mixxxdj:master Apr 22, 2015
@rryan
Copy link
Member

rryan commented Apr 22, 2015

Merged manually (it had conflicts).

esbrandt added a commit to mixxxdj/manual that referenced this pull request Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants