Improve robustness when seeking in "flaky" FLAC files #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix seek errors that have been reported for some FLAC files: http://www.mixxx.org/forums/viewtopic.php?f=3&t=7340 Linear decoding of those files works without any errors. Nevertheless those files should be re-encoded without loss of information.
|
LGTM. Thank you very much for the fix. |
daschuer
added a commit
that referenced
this pull request
Jul 26, 2015
Improve robustness when seeking in "flaky" FLAC files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry on seek errors in "flaky" FLAC files
This will fix seek errors that have been reported for some FLAC files:
http://www.mixxx.org/forums/viewtopic.php?f=3&t=7340
Linear decoding of those files works without any errors. Nevertheless
those files should be re-encoded without loss of information.