Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added random sort "easter egg" and added tooltip for the random sort #908

Merged
merged 2 commits into from Mar 23, 2016
Merged

Added random sort "easter egg" and added tooltip for the random sort #908

merged 2 commits into from Mar 23, 2016

Conversation

jmigual
Copy link
Contributor

@jmigual jmigual commented Mar 22, 2016

Hello,
I have added thhe random sort discussed in bug #1447082

The random sort is discused in bug \# 1447082
@daschuer
Copy link
Member

Thank you for the PR. It works :-)
On order to merge this, you need to become a contributor.
Please sign: https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ

and comment here when done.

BaseSqlTableModel::setSort(column, order);

// Random sort easter egg, only in library view
if (column == 1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use
fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_PREVIEW)
to make the code robust against future changes.

@daschuer
Copy link
Member

Some extra findings, but nothing that stops us from merging:

Playing with it the sorting arrow on the preview header feels misplaces since random has no reverse.

It would be cool to have a the soring hierarchy working with random.
Use case. sort random and than sort by star rating. Result: random soring of all 5 star tracks.

@jmigual
Copy link
Contributor Author

jmigual commented Mar 23, 2016

Ok, now I've made the changes and signed to become a contributor :)

@daschuer
Copy link
Member

Thank you. Are you working on the hierarchical random sort or should we merge this as it is?

@jmigual
Copy link
Contributor Author

jmigual commented Mar 23, 2016

I think we would better merge as it is, but we can add it to the wishlist.

@daschuer daschuer merged commit f28af32 into mixxxdj:master Mar 23, 2016
esbrandt added a commit to esbrandt/manual that referenced this pull request Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants