New Feature: Rating from id3 popm frame translates into star ratings. #924

WaylonR · 2016-04-12T13:57:22Z

This pull request will pull in the id3 popm or Populimeter frame, and translate its rating numbers into stars, and apply them to the database. For existing files, they will have to be 'Reload from file metadata'ed.

daschuer · 2016-04-12T14:08:42Z

src/track/trackmetadatataglib.cpp

@@ -838,6 +838,29 @@ void readTrackMetadataFromID3v2Tag(TrackMetadata* pTrackMetadata,
        parseTrackPeak(pTrackMetadata,
                toQString(pTrackPeakFrame->fieldList()[1]));
    }
+    TagLib::ID3v2::FrameList ratingFrame = tag.frameListMap()["POPM"];


// POPM = Popularimeter

daschuer · 2016-04-12T14:49:20Z

Thank you very much for working on this feature. It is a good step towards a universal solution.

We have the issue, that Rating from different sourced can mean different things.
If you search the web for "Using Star rating" or similar, you will find some blog with different opinions how to use them.

Mainly we can distinguish at least a DJ-Rating from an Personal rating. Thats why I think we have to support at least two rating columns, but that is an other issue.

Related bugs:
https://bugs.launchpad.net/mixxx/+bug/973136
https://bugs.launchpad.net/mixxx/+bug/973145

Maybe we can setup the rating user as preference option.
How about to store Mixxx rating as mixxx@mixxx.org by default?
Adopting the Traktor rating as Mixxx rating should be an extra action.

It looks like your use case will be work perfectly if you set the rating user to "traktor@native-instruments.de"

uklotzde · 2016-04-12T22:15:33Z

src/track/trackmetadata.h

@@ -194,6 +202,7 @@ class TrackMetadata {
    int m_channels;
    int m_duration; // seconds
    int m_sampleRate; // Hz
+    int m_iRating;


TrackMetadata stores tags from various file formats in a portable way, both for reading and writing. I don't recommend to implement it in a way that just works for some special cases and loses information when writing tags back to files as Daniel already mentioned.

The int-rating in Mixxx is just the number of stars displayed on the UI. A portable solution needs to provide a bidirectional mapping between the tags from various file formats and the internal representation.

daschuer · 2016-04-13T06:51:35Z

@WaylonR:
What is your original use case, that has made you do this work? Which applications and OSs are involved?
Maybe there is a chance to allow it in a way that does not prevent the other things discussed here.

WaylonR · 2016-04-13T08:35:17Z

My original cause of doing this is my wife sorting and rating my music (using her personal taste and music charts, with #1's being rated 5 stars), using AudioShell, which uses the Windows Media method of rating. Works well. She uses Windows, I use Mixxx under linux, its my only library organizing software.

daschuer · 2016-04-13T15:46:31Z

OK, so it looks like we need a mass import of the Windows Media Player ratings to Mixxx ratings.
Picking the first rating we found might work for the fist version.
This would be normally a context menu feature, but the context menu is already a bit cluttered.
Any other idea?

WaylonR · 2016-04-14T04:18:01Z

id suggest making a preference to set 'Import ratings to mixxx star
ratings' with the caution 'overwrites pre-existing star ratings' and let
the metadata reload (an action that a user does, knowing that it
overwrites customized mixxx data) or the new file import update the
ratings. This, for the first version of the feature. There are some dj's
who use external tagging software to tag their files, and mixxx is just
the library to show and search. Thats what I do. The master metadata is
in the id3 tags.

On 14/04/16 03:46, Daniel Schürmann wrote:

OK, so it looks like we need a mass import of the Windows Media Player
ratings to Mixxx ratings.
Picking the first rating we found might work for the fist version.
This would be normally a context menu feature, but the context menu is
already a bit cluttered.
Any other idea?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#924 (comment)

daschuer · 2016-04-14T06:23:13Z

This would work for me as a first shot.

This check-box can placed along with "[Library]","WriteAudioTags"
https://github.com/mixxxdj/mixxx/blob/master/src/preferences/dialog/dlgpreflibrary.cpp#L301

And can be evaluated here:

mixxx/src/widget/wtracktableview.cpp

Line 1319 in 9a424c9

SoundSourceProxy(pTrack).loadTrackMetadata(true);

Do you need some more hints to make it real?

Merging changes from master to id3ratings_to_stars

…dialog.

LindyBalboa · 2016-11-13T10:00:29Z

I'm guessing this PR has kind of died? This is of major interest to me because I am trying to move from Windows to Linux and there is no replacement for MediaMonkey, which stores all ratings as POPM. I plan on forking Mixxx to really make it do what I need to generally, but this is a feature I could definitely do for main branch. I actually already did it mostly for a music player I started designing but scrapped.

I'm kind of low on free time right now, but it is a big deal for me so I will find some time. Should I jump ahead on this?

daschuer · 2016-11-13T15:39:14Z

@LindyBalboa It would be great, if you will jump in here helping us to move this into a mere-gable state.

A great benefit of Mixxx is that it is already highly flexible and customizable. However, we have not managed to a add all features required to be a full media player replacement yet (I personally use Clementine as personal media-player for that reason).

I am happy to accept pull requests for upstream, adding these missing features. So there should be no reason to actually fork Mixxx. We have to keep in mind that Mixxx's first purpose is live DJ-ing though.

Some time ago we have discussed to add two modes to Mixxx: Live mode and Prepare mode. This could also be a good approach if you plan to move away from the Live DJ use case.

daschuer · 2016-11-13T15:39:34Z

@WaylonR How are your planes here? What is missing to merge this to master? How can @LindyBalboa support you?

In order to merge this to master we need your permission. Please sign:

https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ

and comment here when done. Thank you

LindyBalboa · 2016-11-13T18:41:34Z

@daschuer There were a few features that I personally would find useful but wasn't sure if they would fit in with the goals of Mixxx. My main use for a music player aside from personal use is to DJ for Swing dancing. This has different needs than club DJs.

Two items I would want to implement are:

Having a pre-queue playlist visible in order to pre-select more than the next song via the other deck. I think this feature is available in Apple DJay.
Built in delay between songs i.e. set 0.5s-3s between the end of the previous track and the next.

There were many more ideas I had, but it is Sunday evening and I am feeling to lazy to hunt down the list. My main concern was if #1 fit in or not. If that is something the main devs would be okay with, I would be happy to try and add that for Mixxx.

daschuer · 2016-11-13T19:53:32Z

Swing DJs should belong to Mixxx's first class citizen!

IMHO 1) is already implemented in #991 and will be merged soon.
There you can view the library table and the AutoDJ playlist usable as pre-queue playlist side by side.
Please try it out, we are looking forward to your comments.

If you use AutoDJ, you can set the fade time negative to achieve a pause. However https://bugs.launchpad.net/mixxx/+bug/673515 and https://bugs.launchpad.net/mixxx/+bug/1106813 could be useful to implement

There were many more ideas I had, but it is Sunday evening and I am feeling to lazy to hunt down the list.

Please file a bug for every item on your list at: https://bugs.launchpad.net/mixxx/+filebug

LindyBalboa · 2016-11-14T23:27:00Z

Super. That is pretty much what my first stab at implementing that was going to be. Will take a look at the pause stuff.

The other big thing I feel is missing is a more advanced search option. I really like how mediamonkey does their search. Is something like that in the works? If not I got pretty far with a clone of it in my last project.

daschuer · 2016-11-14T23:58:09Z

Do you know this: https://www.mixxx.org/manual/latest/chapters/library.html#finding-tracks-search
Please file bugs for missing search queries or GUI ideas!

WaylonR · 2016-11-15T04:55:47Z

It isn't ready yet, i haven't successfully hooked the UI options in, but
i have got it working, importing the popm info into the database, as the
stars.. so its always on by default. I'll review what ive done, and do
one more push before I ask for merge.

On 14/11/16 04:39, Daniel Schürmann wrote:

@WaylonR https://github.com/WaylonR How are your planes here? What
is missing to merge this to master? How can @LindyBalboa
https://github.com/LindyBalboa support you?

In order to merge this to master we need your permission. Please sign:

https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ

and comment here when done. Thank you

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#924 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AQ5ee6GnVC_D-d3aiOm057LQMafax3qcks5q9y83gaJpZM4IFaj3.

LindyBalboa · 2016-11-16T10:39:35Z

It looks like this is only implemented for ID3, but not Xiph, APE, or MP4/M4A. I would say those are rather critical pieces to the puzzle especially Xiph and MP4 because of audiophiles and itunes users.

uklotzde · 2016-11-16T16:55:18Z

This is what I already mentioned when I reviewed this comment sometime ago:
#924 (comment)

The implementation is still incomplete and currently only fits one special
use case.

You may also should consider rebasing this branch on master before working
on it again. There are already some minor merge conflicts. Don't hesitate to
contact me, if you need any help.

On 16.11.2016 11:39, Conner Phillips wrote:

It looks like this is only implemented for ID3, but not Xiph, APE, or
MP4/M4A. I would say those are rather critical pieces to the puzzle
especially Xiph and MP4 because of audiophiles and itunes users.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#924 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/ABZ-au6Wriuwu58FUdP7f_rar1WawaH9ks5q-t1pgaJpZM4IFaj3.

illuusio · 2017-04-26T06:09:35Z

Actually is this PR duplicate of more advanced #1089?

WaylonR · 2017-04-26T08:00:23Z

Its the prototype, the conceptulation of #1089. I never got back to it, been so busy with other things, that instead of continuing #924, they created a new PR. Okay, strange way of doing things but okay. If i ever develop it any further, id build on #1089, instead of my own working code.

…

On 26/04/17 18:09, Tuukka Pasanen wrote: Actually is this PR duplicate of more advanced #1089 <#1089>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#924 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQ5ee3GLEs2MGhWOjz6kfOSMUwDWy_reks5rzt-hgaJpZM4IFaj3>.

uklotzde · 2017-12-02T10:40:22Z

@WaylonR Is it ok for you that we close this PR since there already is a successor and now many merge conflicts? I'm trying to do some housekeeping to get a better overview about what PRs are actually active and need to be reviewed.

WaylonR · 2017-12-02T23:18:59Z

Yes, thank you.

New Feature: Rating from id3 popm frame translates into star ratings.

d5917a6

daschuer reviewed Apr 12, 2016
View reviewed changes

uklotzde reviewed Apr 12, 2016
View reviewed changes

WaylonR added 2 commits April 17, 2016 17:01

Merge remote-tracking branch 'upstream/master' into id3ratings_to_stars

120e151

Merging changes from master to id3ratings_to_stars

Attempt #1 to include updating ratings from mp3's as a preference in …

f13b110

…dialog.

LindyBalboa mentioned this pull request Dec 23, 2016

Add reading of rating tag for MP3, MP4, and FLAC #1089

Closed

uklotzde added the stale? label Oct 29, 2017

WaylonR closed this Dec 2, 2017

mixxxbot mentioned this pull request Aug 23, 2022

Saving ratings in file tags #9477

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Feature: Rating from id3 popm frame translates into star ratings. #924

New Feature: Rating from id3 popm frame translates into star ratings. #924

WaylonR commented Apr 12, 2016

daschuer Apr 12, 2016

daschuer commented Apr 12, 2016

uklotzde Apr 12, 2016

daschuer commented Apr 13, 2016

WaylonR commented Apr 13, 2016

daschuer commented Apr 13, 2016

WaylonR commented Apr 14, 2016

daschuer commented Apr 14, 2016

LindyBalboa commented Nov 13, 2016

daschuer commented Nov 13, 2016

daschuer commented Nov 13, 2016

LindyBalboa commented Nov 13, 2016

daschuer commented Nov 13, 2016

LindyBalboa commented Nov 14, 2016

daschuer commented Nov 14, 2016

WaylonR commented Nov 15, 2016

LindyBalboa commented Nov 16, 2016

uklotzde commented Nov 16, 2016

illuusio commented Apr 26, 2017

WaylonR commented Apr 26, 2017 via email

uklotzde commented Dec 2, 2017

WaylonR commented Dec 2, 2017

New Feature: Rating from id3 popm frame translates into star ratings. #924

New Feature: Rating from id3 popm frame translates into star ratings. #924

Conversation

WaylonR commented Apr 12, 2016

daschuer Apr 12, 2016

Choose a reason for hiding this comment

daschuer commented Apr 12, 2016

uklotzde Apr 12, 2016

Choose a reason for hiding this comment

daschuer commented Apr 13, 2016

WaylonR commented Apr 13, 2016

daschuer commented Apr 13, 2016

WaylonR commented Apr 14, 2016

daschuer commented Apr 14, 2016

LindyBalboa commented Nov 13, 2016

daschuer commented Nov 13, 2016

daschuer commented Nov 13, 2016

LindyBalboa commented Nov 13, 2016

daschuer commented Nov 13, 2016

LindyBalboa commented Nov 14, 2016

daschuer commented Nov 14, 2016

WaylonR commented Nov 15, 2016

LindyBalboa commented Nov 16, 2016

uklotzde commented Nov 16, 2016

illuusio commented Apr 26, 2017

WaylonR commented Apr 26, 2017 via email

uklotzde commented Dec 2, 2017

WaylonR commented Dec 2, 2017