mp4 crash fix #968
Merged
mp4 crash fix #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Limit to an insane high value of 1 MB, | ||
| // we got 4278190742 in https://bugs.launchpad.net/mixxx/+bug/1594169 | ||
| // TODO() set this to the mp4 maximum allowed block size, if there is one | ||
| qWarning() << "maxSampleBlockInputSize is to big:" << maxSampleBlockInputSize << getUrlString(); |
|
thanks for the fix @daschuer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for https://bugs.launchpad.net/mixxx/+bug/1594169
It turns out that Mixxx crashes, because of a rethrowed exception.
I think it is better to consume the exception in this case, since crashing is not a good alternative here. The exception is most likely caused by an faulty file (like int this case). If the system is unstable, it can crash later ;-)
I have also added a plausibility check that completely avoid the bad_alloc exception from this bug.
I have not found a limit for SampleBlockSize in the mp4 docs, so I pick an insane value of 1 MB